Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix placement of "Integrations" button #5497

Merged
merged 3 commits into from
Nov 20, 2024

Conversation

jpople
Copy link
Contributor

@jpople jpople commented Nov 15, 2024

Closes HJ-173

Description Of Changes

Fixes positioning of "Integrations" button on system page.

Before:
Screenshot 2024-11-14 at 23 14 53

After:
Screenshot 2024-11-14 at 23 15 15

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
  • Followup issues:
    • Followup issues created (include link)
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

Copy link

vercel bot commented Nov 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fides-plus-nightly ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 20, 2024 6:35am

Copy link

cypress bot commented Nov 15, 2024

fides    Run #11098

Run Properties:  status check passed Passed #11098  •  git commit 33df2df921 ℹ️: Merge d3e8c6e0568caf4d40dfe8adaf1c5559309b46f5 into 6ea0944dba5e43dbe7f70010201f...
Project fides
Branch Review refs/pull/5497/merge
Run status status check passed Passed #11098
Run duration 00m 41s
Commit git commit 33df2df921 ℹ️: Merge d3e8c6e0568caf4d40dfe8adaf1c5559309b46f5 into 6ea0944dba5e43dbe7f70010201f...
Committer jpople
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

@Kelsey-Ethyca
Copy link
Contributor

Kelsey-Ethyca commented Nov 20, 2024

Screen.Recording.2024-11-19.at.4.22.39.PM.mov

@jpople jpople merged commit 30c4464 into main Nov 20, 2024
13 checks passed
@jpople jpople deleted the jpople/hj-173/integration-button-placement-fix branch November 20, 2024 06:52
Copy link

cypress bot commented Nov 20, 2024

fides    Run #11099

Run Properties:  status check passed Passed #11099  •  git commit 30c4464806: Fix placement of "Integrations" button (#5497)
Project fides
Branch Review main
Run status status check passed Passed #11099
Run duration 00m 39s
Commit git commit 30c4464806: Fix placement of "Integrations" button (#5497)
Committer jpople
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants