Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing BigQuery fixture #5491

Merged
merged 3 commits into from
Nov 13, 2024
Merged

Fixing BigQuery fixture #5491

merged 3 commits into from
Nov 13, 2024

Conversation

galvana
Copy link
Contributor

@galvana galvana commented Nov 13, 2024 •
edited
Loading

Closes LA-147

Description Of Changes

Fixing an issue with a fixture used by BigQuery tests. See inline comments for details.

Code Changes

  • Updated fixture

Steps to Confirm

  1. All CI tests should pass

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
  • Followup issues:
    • Followup issues created (include link)
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

@vercel Vercel
Copy link

vercel bot commented Nov 13, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
fides-plus-nightly ⬜️ Ignored (Inspect) Visit Preview Nov 13, 2024 6:57pm

@galvana galvana added the run unsafe ci checks Runs fides-related CI checks that require sensitive credentials label Nov 13, 2024
@galvana galvana marked this pull request as ready for review November 13, 2024 18:43
@cypress Cypress
Copy link

cypress bot commented Nov 13, 2024 •
edited
Loading

fides    Run #10981

Run Properties:  status check passed Passed #10981  •  git commit ef2fe94838 ℹ️: Merge 0dc384d17d79b55d86e6cce7680e5b3cb6ac1cd4 into b74f1b80bc06a73fff9045508fa7...
Project fides
Branch Review refs/pull/5491/merge
Run status status check passed Passed #10981
Run duration 00m 39s
Commit git commit ef2fe94838 ℹ️: Merge 0dc384d17d79b55d86e6cce7680e5b3cb6ac1cd4 into b74f1b80bc06a73fff9045508fa7...
Committer Adrian Galvan
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

@galvana galvana merged commit aa9155a into main Nov 13, 2024
16 of 17 checks passed
@galvana galvana deleted the LA-147-fix-bigquery-fixture branch November 13, 2024 19:08
@cypress Cypress
Copy link

cypress bot commented Nov 13, 2024

fides    Run #10982

Run Properties:  status check passed Passed #10982  •  git commit aa9155af32: Fixing BigQuery fixture (#5491)
Project fides
Branch Review main
Run status status check passed Passed #10982
Run duration 00m 37s
Commit git commit aa9155af32: Fixing BigQuery fixture (#5491)
Committer Adrian Galvan
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erosselli erosselli erosselli approved these changes

Assignees
No one assigned
Labels
run unsafe ci checks Runs fides-related CI checks that require sensitive credentials
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@galvana @erosselli