Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LA-128 Write-docs-for-our-region-codes #5488

Merged
merged 5 commits into from
Nov 12, 2024

Conversation

lucanovera
Copy link
Contributor

@lucanovera lucanovera commented Nov 12, 2024

Description Of Changes

Add docs about our PrivacyNoticeRegion.

Code Changes

  • Added page about our PrivacyNoticeRegion
  • Added links to the next PrivacyNoticeRegion page
  • Disabled format on save for markdown files since prettier was removing the new lines causing issues

Screenshots

Captura de pantalla 2024-11-12 a la(s) 1 55 57 p  m Captura de pantalla 2024-11-12 a la(s) 1 56 16 p  m

Steps to Confirm

  1. Run fidesdocs
  2. Visit http://localhost:3000/docs/dev-docs/js/reference/types/PrivacyNoticeRegion

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
  • Documentation:

Copy link

vercel bot commented Nov 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
fides-plus-nightly ⬜️ Ignored (Inspect) Visit Preview Nov 12, 2024 6:00pm

Copy link

cypress bot commented Nov 12, 2024

fides    Run #10959

Run Properties:  status check passed Passed #10959  •  git commit a616d72c7b ℹ️: Merge a345049fc218c90f2d457a2374ffff26d9b34966 into 718ce558f542e2797a129f7870a1...
Project fides
Branch Review refs/pull/5488/merge
Run status status check passed Passed #10959
Run duration 00m 41s
Commit git commit a616d72c7b ℹ️: Merge a345049fc218c90f2d457a2374ffff26d9b34966 into 718ce558f542e2797a129f7870a1...
Committer Lucano Vera
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

Copy link
Contributor

@eastandwestwind eastandwestwind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@lucanovera lucanovera merged commit dd3ffd5 into main Nov 12, 2024
13 checks passed
@lucanovera lucanovera deleted the LA-128-Write-docs-for-our-region-codes branch November 12, 2024 18:37
Copy link

cypress bot commented Nov 12, 2024

fides    Run #10960

Run Properties:  status check passed Passed #10960  •  git commit dd3ffd5e83: LA-128 Write-docs-for-our-region-codes (#5488)
Project fides
Branch Review main
Run status status check passed Passed #10960
Run duration 00m 37s
Commit git commit dd3ffd5e83: LA-128 Write-docs-for-our-region-codes (#5488)
Committer Lucano Vera
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants