LA-41 Update POST endpoints for data categories, subjects and uses for new taxonomy functionality #5468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
fides
|
||||||||||||||||||||||||||||||
| Project |
fides
|
| Branch Review |
refs/pull/5468/merge
|
| Run status |
|
| Run duration | 00m 39s |
| Commit |
|
| Committer | Catherine Smith |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
4
|
Upgrade your plan to view test results. | |
| View all changes introduced in this branch ↗︎ | |
galvana
reviewed
Nov 6, 2024
| model.active is False, | ||
| ) | ||
| if disabled_resource_with_name: | ||
| return model.update(db=db, data=disabled_resource_with_name, active=True) # type: ignore[union-attr] |
There was a problem hiding this comment.
What happens if the incoming data doesn't match the DB model we're reactivating? Should we pass in the incoming data instead of the disabled_resource_with_name?
Suggested change
| return model.update(db=db, data=disabled_resource_with_name, active=True) # type: ignore[union-attr] | |
| return model.update(db=db, data=data, active=True) # type: ignore[union-attr] |
There was a problem hiding this comment.
Yes good call!
galvana
approved these changes
Nov 19, 2024
fides
|
||||||||||||||||||||||||||||||
| Project |
fides
|
| Branch Review |
main
|
| Run status |
|
| Run duration | 00m 37s |
| Commit |
|
| Committer | Catherine Smith |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
|
Failures
|
0
|
|
Flaky
|
0
|
|
Pending
|
0
|
|
Skipped
|
0
|
|
Passing
|
4
|
Upgrade your plan to view test results. | |
| View all changes introduced in this branch ↗︎ | |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://ethyca.atlassian.net/browse/LA-41
Description Of Changes
Update POST endpoints for data categories, subjects and uses for new taxonomy functionality. Specifically enables us to do 2 things:
Code Changes
Steps to Confirm
/data_use, POST/data_category, and POST/data_subejct. Confirm that you can create a resource without having to specify a fides keyPre-Merge Checklist
CHANGELOG.mdmaindowngrade()migration is correct and works