-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HJ-58: migrate dataset field names #5461
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
fides Run #10863
Run Properties:
|
Project |
fides
|
Branch Review |
refs/pull/5461/merge
|
Run status |
Passed #10863
|
Run duration | 00m 39s |
Commit |
67ff4a61f8 ℹ️: Merge e78b2fc2c8b13115b94a8a99e80c7526acdfda6f into 55d34540d154f44c642c0da954c6...
|
Committer | Kirk Hardy |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
0
|
Pending |
0
|
Skipped |
0
|
Passing |
4
|
Upgrade your plan to view test results. | |
View all changes introduced in this branch ↗︎ |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5461 +/- ##
==========================================
- Coverage 85.42% 85.33% -0.09%
==========================================
Files 385 385
Lines 24152 24185 +33
Branches 2630 2635 +5
==========================================
+ Hits 20631 20638 +7
- Misses 2967 2993 +26
Partials 554 554 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested manually and it worked
fides Run #10862
Run Properties:
|
Project |
fides
|
Branch Review |
main
|
Run status |
Passed #10862
|
Run duration | 00m 37s |
Commit |
66ec9d2d89: HJ-58: migrate dataset field names (#5461)
|
Committer | Kirk Hardy |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
0
|
Pending |
0
|
Skipped |
0
|
Passing |
4
|
Upgrade your plan to view test results. | |
View all changes introduced in this branch ↗︎ |
Closes #HJ-58
Description Of Changes
Adds an endpoint that can be called which repairs field names in datasets from the old dot-separated sub field names to the new, trimmed, source names
Code Changes
parent.child.grandchild
tograndchild
, updates thectl_datasets
row with the new collectionSteps to Confirm
name.sub_name
sub_name
Pre-Merge Checklist
CHANGELOG.md
main
downgrade()
migration is correct and works