Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HJ-58: migrate dataset field names #5461

Merged
merged 16 commits into from
Nov 6, 2024

Conversation

thingscouldbeworse
Copy link
Contributor

@thingscouldbeworse thingscouldbeworse commented Nov 5, 2024

Closes #HJ-58

Description Of Changes

Adds an endpoint that can be called which repairs field names in datasets from the old dot-separated sub field names to the new, trimmed, source names

Code Changes

  • add /datasets/clean, and endpoint which extracts all existing datasets, changes the field names in the collections from parent.child.grandchild to grandchild, updates the ctl_datasets row with the new collection

Steps to Confirm

  • add any dataset you wish through the UI. Add some nested fields with names with dots, ie name.sub_name
  • hit the endpoint through swagger
  • confirm the names are now changed to just sub_name

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Documentation:
    • documentation complete, PR opened in fidesdocs
    • documentation issue created in fidesdocs
    • if there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
  • Issue Requirements are Met
  • Relevant Follow-Up Issues Created
  • Update CHANGELOG.md
  • For API changes, the Postman collection has been updated
  • If there are any database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!

Copy link

vercel bot commented Nov 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fides-plus-nightly ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 6, 2024 9:04pm

Copy link

cypress bot commented Nov 5, 2024

fides    Run #10863

Run Properties:  status check passed Passed #10863  •  git commit 67ff4a61f8 ℹ️: Merge e78b2fc2c8b13115b94a8a99e80c7526acdfda6f into 55d34540d154f44c642c0da954c6...
Project fides
Branch Review refs/pull/5461/merge
Run status status check passed Passed #10863
Run duration 00m 39s
Commit git commit 67ff4a61f8 ℹ️: Merge e78b2fc2c8b13115b94a8a99e80c7526acdfda6f into 55d34540d154f44c642c0da954c6...
Committer Kirk Hardy
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

@thingscouldbeworse thingscouldbeworse marked this pull request as ready for review November 5, 2024 21:24
Copy link

codecov bot commented Nov 6, 2024

Codecov Report

Attention: Patch coverage is 21.21212% with 26 lines in your changes missing coverage. Please review.

Project coverage is 85.33%. Comparing base (5ca600a) to head (c41db1b).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...rc/fides/api/api/v1/endpoints/dataset_endpoints.py 21.21% 26 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5461      +/-   ##
==========================================
- Coverage   85.42%   85.33%   -0.09%     
==========================================
  Files         385      385              
  Lines       24152    24185      +33     
  Branches     2630     2635       +5     
==========================================
+ Hits        20631    20638       +7     
- Misses       2967     2993      +26     
  Partials      554      554              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@erosselli erosselli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested manually and it worked

@thingscouldbeworse thingscouldbeworse merged commit 66ec9d2 into main Nov 6, 2024
13 of 14 checks passed
@thingscouldbeworse thingscouldbeworse deleted the HJ-58_migrate-bad-nested-names branch November 6, 2024 21:01
@thingscouldbeworse thingscouldbeworse restored the HJ-58_migrate-bad-nested-names branch November 6, 2024 21:04
Copy link

cypress bot commented Nov 6, 2024

fides    Run #10862

Run Properties:  status check passed Passed #10862  •  git commit 66ec9d2d89: HJ-58: migrate dataset field names (#5461)
Project fides
Branch Review main
Run status status check passed Passed #10862
Run duration 00m 37s
Commit git commit 66ec9d2d89: HJ-58: migrate dataset field names (#5461)
Committer Kirk Hardy
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

@thingscouldbeworse thingscouldbeworse deleted the HJ-58_migrate-bad-nested-names branch November 11, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants