Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HJ-138 - Added a security setting that must be set to true to enable the access request download feature #5451

Merged
merged 5 commits into from
Nov 4, 2024
Merged

HJ-138 - Added a security setting that must be set to true to enable the access request download feature #5451

merged 5 commits into from
Nov 4, 2024

Conversation

andres-torres-marroquin
Copy link
Contributor

@andres-torres-marroquin andres-torres-marroquin commented Nov 4, 2024 •
edited
Loading

Closes #HJ-138

Description Of Changes

Added a security setting that must be set to true to enable the access request download feature

Code Changes

  • Updated route get_access_results_urls and its tests

Steps to Confirm

  • Enable "Download access request results" on "About Fides"
  • Setup a variable on .env: FIDES__SECURITY__SUBJECT_REQUEST_DOWNLOAD_UI_ENABLED as true or false
  • Create a privacy request on the demo site
  • Open it on the Admin UI
  • See the button being disabled if FIDES__SECURITY__SUBJECT_REQUEST_DOWNLOAD_UI_ENABLED==false

Screenshot 2024-11-04 at 9 13 53 a m

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Documentation:
    • documentation complete, PR opened in fidesdocs
    • documentation issue created in fidesdocs
    • if there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
  • Issue Requirements are Met
  • Relevant Follow-Up Issues Created
  • Update CHANGELOG.md
  • For API changes, the Postman collection has been updated
  • If there are any database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!

@vercel Vercel
Copy link

vercel bot commented Nov 4, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
fides-plus-nightly ⬜️ Ignored (Inspect) Visit Preview Nov 4, 2024 11:15pm

@andres-torres-marroquin andres-torres-marroquin marked this pull request as ready for review November 4, 2024 15:14
@cypress Cypress
Copy link

cypress bot commented Nov 4, 2024 •
edited
Loading

fides    Run #10773

Run Properties:  status check passed Passed #10773  •  git commit 37480ed2c0 ℹ️: Merge a5905908884bca6b21b85ab78645e21a5debac47 into e3d2fe8c03f4294a9425bdacdf9d...
Project fides
Branch Review refs/pull/5451/merge
Run status status check passed Passed #10773
Run duration 00m 38s
Commit git commit 37480ed2c0 ℹ️: Merge a5905908884bca6b21b85ab78645e21a5debac47 into e3d2fe8c03f4294a9425bdacdf9d...
Committer Andres Torres
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
View all changes introduced in this branch ↗︎

@codecov Codecov
Copy link

codecov bot commented Nov 4, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.47%. Comparing base (e5f240d) to head (a590590).
Report is 3 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #5451   +/-   ##
=======================================
  Coverage   85.47%   85.47%           
=======================================
  Files         384      384           
  Lines       24116    24119    +3     
  Branches     2624     2625    +1     
=======================================
+ Hits        20612    20615    +3     
  Misses       2950     2950           
  Partials      554      554

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

galvana
galvana requested changes Nov 4, 2024
View reviewed changes
src/fides/api/api/v1/endpoints/privacy_request_endpoints.py Outdated Show resolved Hide resolved
tests/ops/test_helpers/decorators.py Outdated Show resolved Hide resolved
galvana
galvana approved these changes Nov 4, 2024
View reviewed changes
Copy link
Contributor

@galvana galvana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the changes! I just made a few more recommendations but I'll approve this now to not block this further

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
src/fides/api/api/v1/endpoints/privacy_request_endpoints.py Outdated Show resolved Hide resolved
src/fides/api/api/v1/endpoints/privacy_request_endpoints.py Show resolved Hide resolved
tests/ops/api/v1/endpoints/test_privacy_request_endpoints.py Outdated Show resolved Hide resolved
@andres-torres-marroquin andres-torres-marroquin changed the title HJ-138 - Add an environment variable that must be true to enable the Access request download feature HJ-138 - Added a security setting that must be set to true to enable the access request download feature Nov 4, 2024
@andres-torres-marroquin andres-torres-marroquin merged commit dc3bfed into main Nov 4, 2024
39 checks passed
@andres-torres-marroquin andres-torres-marroquin deleted the andres/HJ-138 branch November 4, 2024 23:44
@cypress Cypress
Copy link

cypress bot commented Nov 5, 2024

fides    Run #10778

Run Properties:  status check passed Passed #10778  •  git commit dc3bfed3fc: HJ-138 - Added a security setting that must be set to true to enable the access ...
Project fides
Branch Review main
Run status status check passed Passed #10778
Run duration 00m 37s
Commit git commit dc3bfed3fc: HJ-138 - Added a security setting that must be set to true to enable the access ...
Committer Andres Torres
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@galvana galvana galvana approved these changes

@thingscouldbeworse thingscouldbeworse Awaiting requested review from thingscouldbeworse

@erosselli erosselli Awaiting requested review from erosselli

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andres-torres-marroquin @galvana