Adding retries to new database task sessions #5448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
fides
|
||||||||||||||||||||||||||||||
| Project |
fides
|
| Branch Review |
refs/pull/5448/merge
|
| Run status |
|
| Run duration | 00m 37s |
| Commit |
|
| Committer | Adrian Galvan |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
4
|
Upgrade your plan to view test results. | |
| View all changes introduced in this branch ↗︎ | |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5448 +/- ##
==========================================
+ Coverage 77.00% 85.47% +8.46%
==========================================
Files 384 384
Lines 24116 24122 +6
Branches 2624 2624
==========================================
+ Hits 18571 20618 +2047
+ Misses 4971 2950 -2021
+ Partials 574 554 -20 ☔ View full report in Codecov by Sentry. |
galvana
commented
Nov 1, 2024
galvana
commented
Nov 1, 2024
galvana
commented
Nov 1, 2024
galvana
commented
Nov 1, 2024
galvana
added
the
run unsafe ci checks
galvana
commented
Nov 7, 2024
eastandwestwind
requested changes
Nov 19, 2024
There was a problem hiding this comment.
Awesome work on this @galvana ! I'm excited to have this in prod, as it adds extra polish and resilience to our product 🌟
Just a couple notes / asks, mainly for ease of understanding for future devs.
eastandwestwind
approved these changes
Nov 19, 2024
fides
|
||||||||||||||||||||||||||||||
| Project |
fides
|
| Branch Review |
main
|
| Run status |
|
| Run duration | 00m 39s |
| Commit |
|
| Committer | Adrian Galvan |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
|
Failures
|
0
|
|
Flaky
|
0
|
|
Pending
|
0
|
|
Skipped
|
0
|
|
Passing
|
4
|
Upgrade your plan to view test results. | |
| View all changes introduced in this branch ↗︎ | |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes LA-89
Description Of Changes
This change is intended to resolve an intermittent error we are seeing in production
We haven't been able to reproduce it locally but given the intermittent, and short-lived nature of the issue, we believe a retry should account for these disconnections. We also disabled connection pooling for task workers since we believe this is causing issues https://docs.sqlalchemy.org/en/14/core/pooling.html#using-connection-pools-with-multiprocessing-or-os-fork
Code Changes
DatabaseTask.get_new_session()Steps to Confirm
Pre-Merge Checklist
CHANGELOG.md