HJ-20 remove requirement in fides and fideslang to not have datacategories on subfields

[thingscouldbeworse]

Closes #HJ-20

Description Of Changes

remove the validator on subfields not having data categories

Code Changes

• remove the pydantic validator step about subfield data categories

Steps to Confirm

• add a new dataset via upload that has data categories on subfields, such as

dataset:
- fides_key: example_dataset_issue_hj36
  organization_fides_key: default_organization
  name: example_dataset_issue_hj36
  description: Minimal dataset reproducing issue (HJ-36)
  collections:
    - name: example_table
      fields:
        - name: example_success_field
          description: Can save data category changes
          data_categories:
            - user.device
        - name: example_success_field
          description: Can save data category changes
          data_categories:
            - user.device
        - name: example_nested_field
          data_categories:
            - user.device
          fields:
            - name: example_success_nested_field
              description: Can save data category changes on nested field
              data_categories:
                - user.device
              fields: []

• verify that the dataset uploaded

Pre-Merge Checklist

• All CI Pipelines Succeeded
• Documentation:
  • documentation complete, PR opened in fidesdocs
  • documentation issue created in fidesdocs
  • if there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
• Issue Requirements are Met
• Relevant Follow-Up Issues Created
• Update CHANGELOG.md
• For API changes, the Postman collection has been updated
• If there are any database migrations:
  • Ensure that your downrev is up to date with the latest revision on main
  • Ensure that your downgrade() migration is correct and works
    • If a downgrade migration is not possible for this change, please call this out in the PR description!

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment

Name	Status	Preview	Comments	Updated (UTC)
fides-plus-nightly	⬜️ Ignored (Inspect)	Visit Preview		Nov 6, 2024 9:58pm

[erosselli]

Can we add a test (maybe in the patch dataset yaml endpoint?) that checks that we can successfully add a data category to a non-terminal field?

[cypress]

fides    Run #10865

Run Properties:   Passed #10865  •  18f552941d ℹ️: Merge 31e0abec63a19856ad3ba5d59f87496cc46168e4 into 66ec9d2d89f3dcd4853ce7d03055...

Project	fides
Branch Review	refs/pull/5434/merge
Run status	Passed #10865
Run duration	00m 38s
Commit	18f552941d ℹ️: Merge 31e0abec63a19856ad3ba5d59f87496cc46168e4 into 66ec9d2d89f3dcd4853ce7d03055...
Committer	Kirk Hardy
View all properties for this run ↗︎

---

Test results
Failures	0
Flaky	0
Pending	0
Skipped	0
Passing	4
⚠️ You've recorded test results over your free plan limit. Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

[erosselli]

LGTM! Thanks for adding the change. Don't forget to add the changelog entry and update the requirements once the fideslang PR is released

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.20%. Comparing base (55d3454) to head (31e0abe).
Report is 2 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #5434      +/-   ##
==========================================
- Coverage   85.30%   85.20%   -0.10%     
==========================================
  Files         386      386              
  Lines       24206    24234      +28     
  Branches     2636     2640       +4     
==========================================
  Hits        20649    20649              
- Misses       3004     3032      +28     
  Partials      553      553              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[cypress]

fides    Run #10873

Run Properties:   Passed #10873  •  590d85afb7: HJ-20 remove requirement in fides and fideslang to not have datacategories on su...

Project	fides
Branch Review	main
Run status	Passed #10873
Run duration	00m 38s
Commit	590d85afb7: HJ-20 remove requirement in fides and fideslang to not have datacategories on su...
Committer	Kirk Hardy
View all properties for this run ↗︎

---

Test results
Failures	0
Flaky	0
Pending	0
Skipped	0
Passing	4
⚠️ You've recorded test results over your free plan limit. Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎