Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "download" button icon placement #5409

Merged
merged 3 commits into from
Oct 23, 2024

Conversation

jpople
Copy link
Contributor

@jpople jpople commented Oct 23, 2024

Closes HJ-74

Description Of Changes

Fixes icon placement on "download" buttons on datamap report table and privacy request table so it's no longer off-center.

Before:

Screenshot 2024-10-23 at 01 35 42

After:

Screenshot 2024-10-23 at 01 35 54

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Issue Requirements are Met
  • Update CHANGELOG.md

Copy link

vercel bot commented Oct 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
fides-plus-nightly ⬜️ Ignored (Inspect) Visit Preview Oct 23, 2024 2:47pm

Copy link

cypress bot commented Oct 23, 2024

fides    Run #10569

Run Properties:  status check passed Passed #10569  •  git commit 632771df1d ℹ️: Merge bd28c1b3996f52d2812c8bc4d1c20fdda8c0973f into 9b78de23773046c6be5c305b9b3b...
Project fides
Branch Review refs/pull/5409/merge
Run status status check passed Passed #10569
Run duration 00m 38s
Commit git commit 632771df1d ℹ️: Merge bd28c1b3996f52d2812c8bc4d1c20fdda8c0973f into 9b78de23773046c6be5c305b9b3b...
Committer jpople
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

Copy link

@jack-gale-ethyca jack-gale-ethyca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks so much.

@jpople jpople merged commit 48a7498 into main Oct 23, 2024
11 checks passed
@jpople jpople deleted the jpople/hj-74/download-button-visual-fix branch October 23, 2024 14:48
Copy link

cypress bot commented Oct 23, 2024

fides    Run #10570

Run Properties:  status check passed Passed #10570  •  git commit 48a749864e: Fix "download" button icon placement (#5409)
Project fides
Branch Review main
Run status status check passed Passed #10570
Run duration 00m 39s
Commit git commit 48a749864e: Fix "download" button icon placement (#5409)
Committer jpople
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants