Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dataset reference field styling #5408

Merged
merged 10 commits into from
Oct 23, 2024
Merged

Conversation

jpople
Copy link
Contributor

@jpople jpople commented Oct 23, 2024

Closes PROD-2825

Description Of Changes

Adds a tooltip to and fixes alignment of "Dataset" field on system integration form to match the rest of the fields.

Before:
Screenshot 2024-10-23 at 01 21 37

After:
Screenshot 2024-10-23 at 01 20 44

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Issue Requirements are Met
  • Update CHANGELOG.md

Copy link

vercel bot commented Oct 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
fides-plus-nightly ⬜️ Ignored (Inspect) Visit Preview Oct 23, 2024 5:27pm

Copy link

cypress bot commented Oct 23, 2024

fides    Run #10585

Run Properties:  status check passed Passed #10585  •  git commit 017a678384 ℹ️: Merge 8d46c8969188a3e5f2fe5e59808e54509e5d305a into 9f51bcd2595cd417fcda11da5f1e...
Project fides
Branch Review refs/pull/5408/merge
Run status status check passed Passed #10585
Run duration 00m 37s
Commit git commit 017a678384 ℹ️: Merge 8d46c8969188a3e5f2fe5e59808e54509e5d305a into 9f51bcd2595cd417fcda11da5f1e...
Committer jpople
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

Copy link

@jack-gale-ethyca jack-gale-ethyca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@jpople jpople merged commit 5547ece into main Oct 23, 2024
43 checks passed
@jpople jpople deleted the jpople/prod-2825/dataset-reference-styling branch October 23, 2024 18:34
Copy link

cypress bot commented Oct 23, 2024

fides    Run #10590

Run Properties:  status check passed Passed #10590  •  git commit 5547ecee25: Dataset reference field styling (#5408)
Project fides
Branch Review main
Run status status check passed Passed #10590
Run duration 00m 37s
Commit git commit 5547ecee25: Dataset reference field styling (#5408)
Committer jpople
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants