Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added missing integration icons #5374

Merged
merged 5 commits into from
Oct 15, 2024
Merged

added missing integration icons #5374

merged 5 commits into from
Oct 15, 2024

Conversation

Linker44
Copy link
Contributor

@Linker44 Linker44 commented Oct 14, 2024 •
edited
Loading

Closes #LA-28

Description Of Changes

We were missing icons for some integrations. This pr adds them.

Code Changes

  • fixed gladly svg
  • added shipstation svg
  • added powereviews svg
  • added microsoft advertising svg

Steps to Confirm

  • run ui and check that the logos are present

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Documentation:
    • documentation complete, PR opened in fidesdocs
    • documentation issue created in fidesdocs
    • if there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
  • Issue Requirements are Met
  • Relevant Follow-Up Issues Created
  • Update CHANGELOG.md
  • For API changes, the Postman collection has been updated
  • If there are any database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!

@Linker44 Linker44 self-assigned this Oct 14, 2024
@Linker44 Linker44 requested a review from a team as a code owner October 14, 2024 16:40
@vercel Vercel
Copy link

vercel bot commented Oct 14, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
fides-plus-nightly ⬜️ Ignored (Inspect) Visit Preview Oct 15, 2024 0:33am

@cypress Cypress
Copy link

cypress bot commented Oct 14, 2024 •
edited
Loading

fides    Run #10418

Run Properties:  status check passed Passed #10418  •  git commit c0d998337c ℹ️: Merge c297d206a25eb78ff0070fe786c0cbbb6a08c583 into d30bf76852cd53e818eb32a1f3eb...
Project fides
Run status status check passed Passed #10418
Run duration 00m 40s
Commit git commit c0d998337c ℹ️: Merge c297d206a25eb78ff0070fe786c0cbbb6a08c583 into d30bf76852cd53e818eb32a1f3eb...
Committer Facundo Lopez Janza
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

erosselli
erosselli approved these changes Oct 15, 2024
View reviewed changes
Copy link
Contributor

@erosselli erosselli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, looks good! 😎

@Linker44 Linker44 merged commit ef88dbe into main Oct 15, 2024
37 checks passed
@Linker44 Linker44 deleted the add_missing_integration_logos branch October 15, 2024 14:18
@cypress Cypress
Copy link

cypress bot commented Oct 15, 2024

fides    Run #10427

Run Properties:  status check passed Passed #10427  •  git commit ef88dbe616: added missing integration icons (#5374)
Project fides
Run status status check passed Passed #10427
Run duration 00m 38s
Commit git commit ef88dbe616: added missing integration icons (#5374)
Committer Facundo Lopez Janza
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

@Kelsey-Ethyca Kelsey-Ethyca mentioned this pull request Oct 16, 2024
Merged
14 tasks
Kelsey-Ethyca pushed a commit that referenced this pull request Oct 16, 2024
@Linker44 @Kelsey-Ethyca
added missing integration icons (#5374)
52ffea8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erosselli erosselli erosselli approved these changes

@Vagoasdf Vagoasdf Awaiting requested review from Vagoasdf

Assignees

@Linker44 Linker44

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Linker44 @erosselli