Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LA-16 SSO-Modal-Unexpected-Saves #5365

Merged
merged 2 commits into from
Oct 9, 2024
Merged

LA-16 SSO-Modal-Unexpected-Saves #5365

merged 2 commits into from
Oct 9, 2024

Conversation

lucanovera
Copy link
Contributor

@lucanovera lucanovera commented Oct 9, 2024 •
edited
Loading

Description Of Changes

Fix bug where the SSO Provider form is saved when clicking cancel.

Code Changes

  • Change cancel button type from submit to button

Steps to Confirm

  • Add a new SSO Provider in this screen in admin ui: /settings/organization (it doens't need to be real info)
  • Edit the sso provider, fill the Client ID and Client Secret fields again
  • Open the browser's dev tools and the network tab
  • Click the cancel button on the modal
  • Check that no network requests were made after clicking the cancel button

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Issue Requirements are Met
  • Update CHANGELOG.md

@vercel Vercel
Copy link

vercel bot commented Oct 9, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
fides-plus-nightly ⬜️ Ignored (Inspect) Visit Preview Oct 9, 2024 6:36pm

@lucanovera lucanovera merged commit f427c67 into main Oct 9, 2024
11 of 12 checks passed
@lucanovera lucanovera deleted the LA-16-SSO-Modal-Unexpected-Saves branch October 9, 2024 18:44
@cypress Cypress
Copy link

cypress bot commented Oct 9, 2024 •
edited
Loading

fides    Run #10371

Run Properties:  status check passed Passed #10371  •  git commit ebb8c0f61a ℹ️: Merge bf144282454cef15f962941e8585b7c2d7e77cc8 into 36990231d4ad85b37ce0a9a3263d...
Project fides
Run status status check passed Passed #10371
Run duration 00m 39s
Commit git commit ebb8c0f61a ℹ️: Merge bf144282454cef15f962941e8585b7c2d7e77cc8 into 36990231d4ad85b37ce0a9a3263d...
Committer Lucano Vera
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

@cypress Cypress
Copy link

cypress bot commented Oct 9, 2024

fides    Run #10373

Run Properties:  status check passed Passed #10373  •  git commit f427c67e4a: LA-16 SSO-Modal-Unexpected-Saves (#5365)
Project fides
Run status status check passed Passed #10373
Run duration 00m 41s
Commit git commit f427c67e4a: LA-16 SSO-Modal-Unexpected-Saves (#5365)
Committer Lucano Vera
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andres-torres-marroquin andres-torres-marroquin andres-torres-marroquin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lucanovera @andres-torres-marroquin