Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Adobe Campaign #5364

Merged
merged 5 commits into from
Oct 10, 2024
Merged

Remove Adobe Campaign #5364

merged 5 commits into from
Oct 10, 2024

Conversation

Linker44
Copy link
Contributor

@Linker44 Linker44 commented Oct 9, 2024 •
edited
Loading

Closes #

Description Of Changes

Adobe Campaigns integration endpoints are deprecated and the integration is not being utilized.

Code Changes

  • removed adobe campaign integration

Steps to Confirm

  • create an adobe campagin integration. run nox -s dev and verify it was removed

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Documentation:
    • documentation complete, PR opened in fidesdocs
    • documentation issue created in fidesdocs
    • if there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
  • Issue Requirements are Met
  • Relevant Follow-Up Issues Created
  • Update CHANGELOG.md
  • For API changes, the Postman collection has been updated
  • If there are any database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!

@Linker44 Linker44 requested a review from galvana October 9, 2024 16:20
@Linker44 Linker44 self-assigned this Oct 9, 2024
@Linker44 Linker44 requested a review from a team as a code owner October 9, 2024 16:20
@vercel Vercel
Copy link

vercel bot commented Oct 9, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fides-plus-nightly ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 9, 2024 6:55pm

@Linker44 Linker44 changed the title remove_adobe_campaign_integration Remove Adobe Campagin Oct 9, 2024
@Linker44 Linker44 changed the title Remove Adobe Campagin Remove Adobe Campaign Oct 9, 2024
@cypress Cypress
Copy link

cypress bot commented Oct 9, 2024 •
edited
Loading

fides    Run #10375

Run Properties:  status check passed Passed #10375  •  git commit 06e80c1d0f ℹ️: Merge 05b189a51d70889edb0bf861c1bbe8c91a481d71 into f427c67e4a991c1b0bbf033f9eb0...
Project fides
Run status status check passed Passed #10375
Run duration 00m 39s
Commit git commit 06e80c1d0f ℹ️: Merge 05b189a51d70889edb0bf861c1bbe8c91a481d71 into f427c67e4a991c1b0bbf033f9eb0...
Committer Facundo Lopez Janza
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Kelsey-Ethyca
Kelsey-Ethyca approved these changes Oct 10, 2024
View reviewed changes
Copy link
Contributor

@Kelsey-Ethyca Kelsey-Ethyca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦖

@Kelsey-Ethyca Kelsey-Ethyca merged commit 94f11ab into main Oct 10, 2024
37 checks passed
@Kelsey-Ethyca Kelsey-Ethyca deleted the remove_adobe_campaigns branch October 10, 2024 05:06
@cypress Cypress
Copy link

cypress bot commented Oct 10, 2024

fides    Run #10377

Run Properties:  status check passed Passed #10377  •  git commit 94f11aba32: Remove Adobe Campaign (#5364)
Project fides
Run status status check passed Passed #10377
Run duration 00m 37s
Commit git commit 94f11aba32: Remove Adobe Campaign (#5364)
Committer Facundo Lopez Janza
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kelsey-Ethyca Kelsey-Ethyca Kelsey-Ethyca approved these changes

@galvana galvana Awaiting requested review from galvana

Assignees

@Linker44 Linker44

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Linker44 @Kelsey-Ethyca