Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PROD-2713 - Make the dbname in GoogleCloudSQLPostgresSchema optional #5358

Merged
merged 9 commits into from
Oct 8, 2024
Merged

PROD-2713 - Make the dbname in GoogleCloudSQLPostgresSchema optional #5358

merged 9 commits into from
Oct 8, 2024

Conversation

andres-torres-marroquin
Copy link
Contributor

@andres-torres-marroquin andres-torres-marroquin commented Oct 7, 2024 •
edited
Loading

Closes #PROD-2713

Description Of Changes

For making GoogleCloudSQLPostgresMonitor able to explore every database, now dbname field is now optional

Code Changes

  • Make the dbname in GoogleCloudSQLPostgresSchema optional, but since it is required to connect to Postgres, "postgres" is the default one now.

Steps to Confirm

  • Create a new Integration, dbname should be now optional.

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Documentation:
    • documentation complete, PR opened in fidesdocs
    • documentation issue created in fidesdocs
    • if there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
  • Issue Requirements are Met
  • Relevant Follow-Up Issues Created
  • Update CHANGELOG.md
  • For API changes, the Postman collection has been updated
  • If there are any database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!

@vercel Vercel
Copy link

vercel bot commented Oct 7, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
fides-plus-nightly ⬜️ Ignored (Inspect) Visit Preview Oct 8, 2024 5:06pm

@cypress Cypress
Copy link

cypress bot commented Oct 7, 2024 •
edited
Loading

fides    Run #10347

Run Properties:  status check passed Passed #10347  •  git commit cac25c4e26 ℹ️: Merge fa68545a3eff29f514eac040e1dfb77e1d6eee3d into eb623b6cb81c3d1e1344bd9ce290...
Project fides
Run status status check passed Passed #10347
Run duration 00m 38s
Commit git commit cac25c4e26 ℹ️: Merge fa68545a3eff29f514eac040e1dfb77e1d6eee3d into eb623b6cb81c3d1e1344bd9ce290...
Committer Andres Torres
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4

@andres-torres-marroquin andres-torres-marroquin changed the title Prod 2713 PROD-2713 - Make the dbname in GoogleCloudSQLPostgresSchema optional Oct 7, 2024
@andres-torres-marroquin andres-torres-marroquin marked this pull request as ready for review October 7, 2024 19:39
@codecov Codecov
Copy link

codecov bot commented Oct 7, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 85.31%. Comparing base (eb623b6) to head (fa68545).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/fides/api/service/connectors/sql_connector.py 66.66% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #5358      +/-   ##
==========================================
- Coverage   85.32%   85.31%   -0.01%     
==========================================
  Files         378      378              
  Lines       23991    23994       +3     
  Branches     3218     3218              
==========================================
+ Hits        20470    20471       +1     
- Misses       2931     2932       +1     
- Partials      590      591       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andres-torres-marroquin andres-torres-marroquin added the run unsafe ci checks Runs fides-related CI checks that require sensitive credentials label Oct 7, 2024
eastandwestwind
eastandwestwind requested changes Oct 8, 2024
View reviewed changes
Copy link
Contributor

@eastandwestwind eastandwestwind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, can we just add a CHANGELOG entry?

@andres-torres-marroquin andres-torres-marroquin merged commit 7549403 into main Oct 8, 2024
35 of 42 checks passed
@andres-torres-marroquin andres-torres-marroquin deleted the PROD-2713 branch October 8, 2024 18:56
@cypress Cypress
Copy link

cypress bot commented Oct 8, 2024

fides    Run #10351

Run Properties:  status check passed Passed #10351  •  git commit 7549403267: PROD-2713 - Make the dbname in GoogleCloudSQLPostgresSchema optional (#5358)
Project fides
Run status status check passed Passed #10351
Run duration 00m 37s
Commit git commit 7549403267: PROD-2713 - Make the dbname in GoogleCloudSQLPostgresSchema optional (#5358)
Committer Andres Torres
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4

@Kelsey-Ethyca Kelsey-Ethyca mentioned this pull request Oct 16, 2024
Merged
14 tasks
Kelsey-Ethyca pushed a commit that referenced this pull request Oct 16, 2024
@andres-torres-marroquin @Kelsey-Ethyca
PROD-2713 - Make the dbname in GoogleCloudSQLPostgresSchema optional (#…
0e6492e 
…5358)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erosselli erosselli erosselli left review comments

@eastandwestwind eastandwestwind eastandwestwind approved these changes

Assignees
No one assigned
Labels
run unsafe ci checks Runs fides-related CI checks that require sensitive credentials
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andres-torres-marroquin @eastandwestwind @erosselli