-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce custom reports to Data map #5352
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
gilluminate
force-pushed
the
PROD-2680-fe-introduce-custom-reports
branch
from
October 4, 2024 21:27
0940d87
to
3a3749c
Compare
fides Run #10354
Run Properties:
|
Project |
fides
|
Run status |
Passed #10354
|
Run duration | 00m 38s |
Commit |
8b9580b363 ℹ️: Merge b28b8c43512c44b137bb04ebcd5475adb10956eb into 754940326780bc9e6c259f57ec44...
|
Committer | Jason Gill |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
0
|
Pending |
0
|
Skipped |
0
|
Passing |
4
|
gilluminate
force-pushed
the
PROD-2680-fe-introduce-custom-reports
branch
from
October 7, 2024 22:48
c508b94
to
8364537
Compare
gilluminate
force-pushed
the
PROD-2680-fe-introduce-custom-reports
branch
from
October 8, 2024 17:27
55f17f6
to
a01d469
Compare
for better maintainability
gilluminate
force-pushed
the
PROD-2680-fe-introduce-custom-reports
branch
from
October 8, 2024 17:32
a01d469
to
7ea4cf5
Compare
jpople
reviewed
Oct 8, 2024
clients/admin-ui/src/features/common/custom-reports/CustomReportCreationModal.tsx
Outdated
Show resolved
Hide resolved
jpople
reviewed
Oct 8, 2024
clients/admin-ui/src/features/common/custom-reports/CustomReportTemplates.tsx
Outdated
Show resolved
Hide resolved
jpople
approved these changes
Oct 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯
fides Run #10355
Run Properties:
|
Project |
fides
|
Run status |
Passed #10355
|
Run duration | 00m 38s |
Commit |
c87ca783d3: Introduce custom reports to Data map (#5352)
|
Committer | Jason Gill |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
0
|
Pending |
0
|
Skipped |
0
|
Passing |
4
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes PROD-2680
Description Of Changes
Allow customers to save custom reporting templates. Saved reports are accessible in reporting views with specific filter/grouping/column setting applied. Reports are accessible to everyone in an org/workspace.
The Data map report can be broken down to these various states:
All 7 should persist across sessions (local storage) for when the user reloads their page or returns to the app later.
The saved report should exclude Column Sizing, Column Expand/Collapse, and Column Wrap Results.
Code Changes
DatamapReportTable
component, breaking it up into multiple files for better maintainabilityCustomReportsTemplate
custom popover component with ability to create, load, apply, and delete custom reportsreport_id
to endpoint for downloading reports for backend supportSteps to Confirm
Pre-Merge Checklist
CHANGELOG.md