Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating hash migration status check #5336

Merged

Conversation

galvana
Copy link
Contributor

@galvana galvana commented Sep 26, 2024

Closes PROD-2828

Description Of Changes

Updates the hash migration status check query to use the is_hash_migrated IS FALSE clause instead of is_hash_migrated = FALSE. The indexes for this query are created with IS FALSE so the status check queries were running an inefficient sequential scan on the entire table instead of an optimized index scan.

Steps to Confirm

  • This is tricky to test on a dev environment but as long as the server starts up it means the query still ran and the intended behavior is still preserved.

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Issue Requirements are Met
  • Update CHANGELOG.md

Copy link

vercel bot commented Sep 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
fides-plus-nightly ⬜️ Ignored (Inspect) Visit Preview Sep 26, 2024 9:40pm

Copy link

cypress bot commented Sep 26, 2024

fides    Run #10208

Run Properties:  status check passed Passed #10208  •  git commit e2a8cf1900 ℹ️: Merge 46475cb01ccd0e0d5c4a149a1aa11d9e7bfbaaf9 into 79b3a42bbf55e514e5a6bfab7807...
Project fides
Branch Review refs/pull/5336/merge
Run status status check passed Passed #10208
Run duration 00m 37s
Commit git commit e2a8cf1900 ℹ️: Merge 46475cb01ccd0e0d5c4a149a1aa11d9e7bfbaaf9 into 79b3a42bbf55e514e5a6bfab7807...
Committer Adrian Galvan
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

Copy link
Contributor

@NevilleS NevilleS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@galvana galvana merged commit a6510c1 into main Sep 26, 2024
14 checks passed
@galvana galvana deleted the PROD-2828-update-hash-migration-status-check-to-use-index branch September 26, 2024 21:41
Copy link

cypress bot commented Sep 26, 2024

fides    Run #10209

Run Properties:  status check passed Passed #10209  •  git commit a6510c126e: Updating hash migration status check (#5336)
Project fides
Branch Review main
Run status status check passed Passed #10209
Run duration 00m 39s
Commit git commit a6510c126e: Updating hash migration status check (#5336)
Committer Adrian Galvan
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants