PROD-2818 Update Fides.shopify() integration for Shopify Plus Consent #5329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
eastandwestwind
force-pushed
the
PROD-2818
branch
from
d56773f
to
ddce29d
Compare
fides
|
||||||||||||||||||||||||||||||
| Project |
fides
|
| Branch Review |
refs/pull/5329/merge
|
| Run status |
|
| Run duration | 00m 38s |
| Commit |
|
| Committer | Catherine Smith |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
4
|
Upgrade your plan to view test results. | |
| View all changes introduced in this branch ↗︎ | |
eastandwestwind
force-pushed
the
PROD-2818
branch
from
ddce29d
to
3570d05
Compare
thingscouldbeworse
approved these changes
Sep 25, 2024
fides
|
||||||||||||||||||||||||||||||
| Project |
fides
|
| Branch Review |
main
|
| Run status |
|
| Run duration | 00m 39s |
| Commit |
|
| Committer | Catherine Smith |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
|
Failures
|
0
|
|
Flaky
|
0
|
|
Pending
|
0
|
|
Skipped
|
0
|
|
Passing
|
4
|
Upgrade your plan to view test results. | |
| View all changes introduced in this branch ↗︎ | |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://ethyca.atlassian.net/browse/PROD-2818
Description Of Changes
Updates Fides.shopify() to appropriately push consent to new shopify consent fields, mapped to Fides data uses.
Code Changes
Steps to Confirm
Loom here- https://www.loom.com/share/cbd2dea0919a4706bad28cb360cff6ef
marketing,data_sales_and_sharing,analytics, andfunctionaldata categories.window.Fides.shopify()after fides.js has loadedwindow.Shopify.customerPrivacy.currentVisitorConsent()to view current privacy statuswindow.Shopify.customerPrivacy.currentVisitorConsent()to view updated privacy status. See this mapping for details on what shopify keys map to which Fides notice keysPre-Merge Checklist
CHANGELOG.mdmaindowngrade()migration is correct and works