Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix discovery pagination #5304

Merged
merged 1 commit into from
Sep 19, 2024
Merged

Fix discovery pagination #5304

merged 1 commit into from
Sep 19, 2024

Conversation

lucanovera
Copy link
Contributor

Description Of Changes

Fix discovery pagination. Change was lost due to bad merge.

Code Changes

  • Fix pagination by making filter array persist and not trigger a change in pagination

Steps to Confirm

  • Go to discovery results of a large dataset and try to use pagination

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Issue Requirements are Met
  • Update CHANGELOG.md

@vercel Vercel
Copy link

vercel bot commented Sep 19, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fides-plus-nightly ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 19, 2024 7:05pm

jpople
jpople approved these changes Sep 19, 2024
View reviewed changes
Copy link
Contributor

@jpople jpople left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Confirming this is fixed and working as intended now.

@lucanovera lucanovera merged commit b1d8892 into main Sep 19, 2024
12 checks passed
@lucanovera lucanovera deleted the fix-discovery-pagination branch September 19, 2024 19:17
lucanovera added a commit that referenced this pull request Sep 19, 2024
@lucanovera
Fix discovery pagination (#5304)
fddcb5b 
Co-authored-by: Lucano Vera <[email protected]>
@cypress Cypress
Copy link

cypress bot commented Sep 19, 2024

fides    Run #10001

Run Properties:  status check passed Passed #10001  •  git commit 140580795d ℹ️: Merge 5df6fbc0850754c555cf83d766e7e07d29d1baf1 into 59978cb33e2d6ba234914936f237...
Project fides
Branch Review refs/pull/5304/merge
Run status status check passed Passed #10001
Run duration 00m 36s
Commit git commit 140580795d ℹ️: Merge 5df6fbc0850754c555cf83d766e7e07d29d1baf1 into 59978cb33e2d6ba234914936f237...
Committer Lucano Vera
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

@cypress Cypress
Copy link

cypress bot commented Sep 19, 2024

fides    Run #10004

Run Properties:  status check passed Passed #10004  •  git commit b1d8892471: Fix discovery pagination (#5304)
Project fides
Branch Review main
Run status status check passed Passed #10004
Run duration 00m 36s
Commit git commit b1d8892471: Fix discovery pagination (#5304)
Committer Lucano Vera
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpople jpople jpople approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lucanovera @jpople