Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update fides-no-scroll so it works in all browsers #5299

Merged
merged 1 commit into from
Sep 19, 2024
Merged

update fides-no-scroll so it works in all browsers #5299

merged 1 commit into from
Sep 19, 2024

Conversation

Kelsey-Ethyca
Copy link
Contributor

Description Of Changes

update fides-no-scroll so it works in all browsers (especially safari)

Code Changes

  • update overflow-y: hidden to overflow: hidden

Steps to Confirm

  • ensure a banner will show on the on the fides.js demo page by adding systems with data uses and enabling notices and experiences
  • add fides-no-scroll to the body element on the fides.js demo page
  • verify you cannot scroll
  • verify when exiting the banner you can scroll
  • test this in safari, firefox, chrome, and edge

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Documentation:
    • documentation complete, PR opened in fidesdocs
    • documentation issue created in fidesdocs
    • if there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
  • Issue Requirements are Met
  • Relevant Follow-Up Issues Created
  • Update CHANGELOG.md
  • For API changes, the Postman collection has been updated
  • If there are any database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!

@vercel Vercel
Copy link

vercel bot commented Sep 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
fides-plus-nightly ⬜️ Ignored (Inspect) Sep 18, 2024 11:21pm

@cypress Cypress
Copy link

cypress bot commented Sep 18, 2024

fides    Run #9982

Run Properties:  status check passed Passed #9982  •  git commit d48ae08973 ℹ️: Merge b35bc5cf4f9a5d65dbd8b7db488d458413bfd323 into 0e666f8fbd41a5deee8f7b962936...
Project fides
Branch Review refs/pull/5299/merge
Run status status check passed Passed #9982
Run duration 00m 37s
Commit git commit d48ae08973 ℹ️: Merge b35bc5cf4f9a5d65dbd8b7db488d458413bfd323 into 0e666f8fbd41a5deee8f7b962936...
Committer Kelsey Thomas
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

gilluminate
gilluminate approved these changes Sep 19, 2024
View reviewed changes
Copy link
Contributor

@gilluminate gilluminate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Tested in chromium browsers, Safari, and FF.

@Kelsey-Ethyca Kelsey-Ethyca merged commit cf74271 into main Sep 19, 2024
13 checks passed
@Kelsey-Ethyca Kelsey-Ethyca deleted the KT-no-scroll branch September 19, 2024 01:47
@cypress Cypress
Copy link

cypress bot commented Sep 19, 2024

fides    Run #9987

Run Properties:  status check passed Passed #9987  •  git commit cf742714ca: update fides-no-scroll so it works in all browsers (#5299)
Project fides
Branch Review main
Run status status check passed Passed #9987
Run duration 00m 35s
Commit git commit cf742714ca: update fides-no-scroll so it works in all browsers (#5299)
Committer Kelsey Thomas
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

Kelsey-Ethyca added a commit that referenced this pull request Sep 19, 2024
@Kelsey-Ethyca
update fides-no-scroll so it works in all browsers (#5299)
09fb431
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gilluminate gilluminate gilluminate approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Kelsey-Ethyca @gilluminate