Fix Shopify masking #5282
Merged
Fix Shopify masking #5282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was an inconsistency on the usage of DSR on what information was being presented, which required an if check
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
fides
|
||||||||||||||||||||||||||||||
| Project |
fides
|
| Branch Review |
refs/pull/5282/merge
|
| Run status |
|
| Run duration | 00m 38s |
| Commit |
|
| Committer | Bruno Gutierrez Rios |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
4
|
Upgrade your plan to view test results. | |
| View all changes introduced in this branch ↗︎ | |
Vagoasdf
commented
Sep 24, 2024
| @@ -503,7 +503,7 @@ async def test_shopify_erasure_request_task( | |||
| f"{dataset_name}:customers": 1, | |||
| f"{dataset_name}:blogs": 0, | |||
| f"{dataset_name}:customer_orders": 1, | |||
| f"{dataset_name}:customer_addresses": 1, | |||
There was a problem hiding this comment.
Since we're adding a new address at shipping address, this increases by 1
galvana
requested changes
Sep 25, 2024
CHANGELOG.md
Outdated
| ### Fixed | ||
| - Fix wording in tooltip for Yotpo Reviews [#5274](https://github.com/ethyca/fides/pull/5274) | ||
| - Updated Shopify Datamap in order to ignore country and province values that are required on the erasure API |
There was a problem hiding this comment.
Suggested change
| - Updated Shopify Datamap in order to ignore country and province values that are required on the erasure API | |
| - Updated Shopify dataset in order to flag country, province, and other location values as read-only |
galvana
approved these changes
Sep 25, 2024
fides
|
||||||||||||||||||||||||||||||
| Project |
fides
|
| Branch Review |
main
|
| Run status |
|
| Run duration | 00m 37s |
| Commit |
|
| Committer | Bruno Gutierrez Rios |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
|
Failures
|
0
|
|
Flaky
|
0
|
|
Pending
|
0
|
|
Skipped
|
0
|
|
Passing
|
4
|
Upgrade your plan to view test results. | |
| View all changes introduced in this branch ↗︎ | |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2617
Description Of Changes
Updating the Shopify dataset to avoid sending masked values for country and province
Adding tests for masking values
Code Changes
Steps to Confirm
We've added Shipping Address to the shopify fixtures, and a new test that has a strict policy so it would mask all the values before sending it to Shopify. That checks that the values that we marked as read_only are not masked
Pre-Merge Checklist
CHANGELOG.md