-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update TCF banner button layout/split tcf styles #5204
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
Test summaryRun details
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested in chrome and Firefox, on various resolutions and it looks great! There are a couple resolutions where the buttons exceed the consent table width, but that's okay otherwise it would leave very little room for the text. Also texted with a longer text for the buttons and it wraps nicely on mobile. Approved.
@@ -38,7 +37,6 @@ const ConsentBanner: FunctionComponent<BannerProps> = ({ | |||
className, | |||
isEmbedded, | |||
}) => { | |||
const isMobile = useMediaQuery("(max-width: 768px)"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am glad you were able to remove this :)
Test summaryRun details
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud |
Closes PROD-2609
Description Of Changes
Desktop preview
Mobile preview
Code Changes
fides-tcf.css
fileSteps to Confirm
Note: All changes should only affect TCF Banner. TCF Modal, non-TCF banner, and non-TCF modal should remain unchanged!
Pre-Merge Checklist
CHANGELOG.md