Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update TCF banner button layout/split tcf styles #5204

Merged
merged 4 commits into from
Aug 16, 2024

Conversation

gilluminate
Copy link
Contributor

@gilluminate gilluminate commented Aug 15, 2024

Closes PROD-2609

Description Of Changes

  • change to a full-width footer
  • modify the order and sizing of buttons

Desktop preview

Desktop preview

Mobile preview

Mobile preview

Code Changes

  • Split all TCF related styles into its own, new fides-tcf.css file
  • tweak poistioning of button code for TCF banner
  • Update styles of TCF banner to match new designs (Figma)

Steps to Confirm

  • Visit demo site with a TCF experience (eg. http://localhost:3001/fides-js-demo.html?geolocation=eea)
    • validate position of banner buttons (span the full width of the banner)
    • Right-click and inspect buttons and hover a button (should register 40px high and 180px wide)
  • Switch to responsive design mode and pick a mobile size (or just shrink your window to around 375px.
    • Verify everything looks good for mobile view

Note: All changes should only affect TCF Banner. TCF Modal, non-TCF banner, and non-TCF modal should remain unchanged!

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Issue Requirements are Met
  • Relevant Follow-Up Issues Created
  • Update CHANGELOG.md

Copy link

vercel bot commented Aug 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
fides-plus-nightly ⬜️ Ignored (Inspect) Visit Preview Aug 15, 2024 8:51pm

Copy link

cypress bot commented Aug 15, 2024



Test summary

4 0 0 0


Run details

Project fides
Status Passed
Commit c3883aaf32 ℹ️
Started Aug 15, 2024 9:04 PM
Ended Aug 15, 2024 9:04 PM
Duration 00:36 💡
OS Linux Ubuntu -
Browser Electron 106

View run in Cypress Cloud ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud

Copy link
Contributor

@lucanovera lucanovera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in chrome and Firefox, on various resolutions and it looks great! There are a couple resolutions where the buttons exceed the consent table width, but that's okay otherwise it would leave very little room for the text. Also texted with a longer text for the buttons and it wraps nicely on mobile. Approved.

@@ -38,7 +37,6 @@ const ConsentBanner: FunctionComponent<BannerProps> = ({
className,
isEmbedded,
}) => {
const isMobile = useMediaQuery("(max-width: 768px)");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am glad you were able to remove this :)

@gilluminate gilluminate merged commit 667b2dd into main Aug 16, 2024
13 checks passed
@gilluminate gilluminate deleted the PROD-2609-fides-js-modify-the-layout-of branch August 16, 2024 19:59
Copy link

cypress bot commented Aug 16, 2024



Test summary

4 0 0 0


Run details

Project fides
Status Passed
Commit 667b2dd
Started Aug 16, 2024 8:12 PM
Ended Aug 16, 2024 8:13 PM
Duration 00:38 💡
OS Linux Ubuntu -
Browser Electron 106

View run in Cypress Cloud ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants