-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PROD-2352 helper: get_urn_list method #5192
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Test summaryRun details
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud |
Nice @thingscouldbeworse - if we're here adding this, could we also add the async getter (https://github.com/ethyca/fidesplus/blob/main/src/fidesplus/api/schemas/discovery_monitor.py#L68-L77)? I'd put that in fidesplus out of laziness and just hadn't gotten around to moving it over here! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5192 +/- ##
=======================================
Coverage 86.55% 86.56%
=======================================
Files 362 362
Lines 22727 22740 +13
Branches 3026 3026
=======================================
+ Hits 19671 19684 +13
Misses 2511 2511
Partials 545 545 ☔ View full report in Codecov by Sentry. |
Test summaryRun details
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud |
helps with PROD-2352
Description Of Changes
Allows fetching
Code Changes
get_urn_list
, likeget_urn
but returns list of db results from list of URNsSteps to Confirm
Pre-Merge Checklist
CHANGELOG.md
main
downgrade()
migration is correct and works