Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PROD-2352 helper: get_urn_list method #5192

Merged
merged 10 commits into from
Aug 14, 2024

Conversation

thingscouldbeworse
Copy link
Contributor

helps with PROD-2352

Description Of Changes

Allows fetching

Code Changes

get_urn_list, like get_urn but returns list of db results from list of URNs

Steps to Confirm

  • run tests

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Documentation:
    • documentation complete, PR opened in fidesdocs
    • documentation issue created in fidesdocs
    • if there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
  • Issue Requirements are Met
  • Relevant Follow-Up Issues Created
  • Update CHANGELOG.md
  • For API changes, the Postman collection has been updated
  • If there are any database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!

Copy link

vercel bot commented Aug 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fides-plus-nightly ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 14, 2024 5:52pm

Copy link

cypress bot commented Aug 14, 2024



Test summary

4 0 0 0


Run details

Project fides
Status Passed
Commit 3155e8848a ℹ️
Started Aug 14, 2024 6:01 PM
Ended Aug 14, 2024 6:01 PM
Duration 00:37 💡
OS Linux Ubuntu -
Browser Electron 106

View run in Cypress Cloud ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud

@adamsachs
Copy link
Contributor

adamsachs commented Aug 14, 2024

Nice @thingscouldbeworse - if we're here adding this, could we also add the async getter (https://github.com/ethyca/fidesplus/blob/main/src/fidesplus/api/schemas/discovery_monitor.py#L68-L77)? I'd put that in fidesplus out of laziness and just hadn't gotten around to moving it over here!

Copy link

codecov bot commented Aug 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.56%. Comparing base (791ec84) to head (846bc97).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5192   +/-   ##
=======================================
  Coverage   86.55%   86.56%           
=======================================
  Files         362      362           
  Lines       22727    22740   +13     
  Branches     3026     3026           
=======================================
+ Hits        19671    19684   +13     
  Misses       2511     2511           
  Partials      545      545           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thingscouldbeworse thingscouldbeworse merged commit 5ec7b1c into main Aug 14, 2024
12 of 14 checks passed
@thingscouldbeworse thingscouldbeworse deleted the PROD-2352_helper-get-urns-func branch August 14, 2024 17:49
Copy link

cypress bot commented Aug 14, 2024



Test summary

4 0 0 0


Run details

Project fides
Status Passed
Commit 5ec7b1c
Started Aug 14, 2024 6:01 PM
Ended Aug 14, 2024 6:01 PM
Duration 00:37 💡
OS Linux Ubuntu -
Browser Electron 106

View run in Cypress Cloud ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants