Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to support consent signals #5190

Merged
merged 4 commits into from
Aug 14, 2024

Conversation

galvana
Copy link
Contributor

@galvana galvana commented Aug 14, 2024

Closes #PROD-2346

Description Of Changes

Minor changes needed to support the main feature in Fidesplus

Code Changes

  • Updating SQLAlchemy relationships to be able to access the consent_automation via the connectionconfig. No migration needed, just needed to update the relationship annotation
  • Moving the ConsentWebhookResult wrapper class to be able to add it as the return type for PROCESS_CONSENT_WEBHOOK functions

Steps to Confirm

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Issue Requirements are Met
  • Update CHANGELOG.md

Copy link

vercel bot commented Aug 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
fides-plus-nightly ⬜️ Ignored (Inspect) Visit Preview Aug 14, 2024 2:19am

Copy link

cypress bot commented Aug 14, 2024



Test summary

4 0 0 0


Run details

Project fides
Status Passed
Commit 28367c945e ℹ️
Started Aug 14, 2024 2:32 AM
Ended Aug 14, 2024 2:32 AM
Duration 00:38 💡
OS Linux Ubuntu -
Browser Electron 106

View run in Cypress Cloud ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud

Copy link

codecov bot commented Aug 14, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 5 lines in your changes missing coverage. Please review.

Project coverage is 86.45%. Comparing base (71ae68c) to head (b82a9fe).

Files Patch % Lines
...vice/saas_request/saas_request_override_factory.py 33.33% 2 Missing and 2 partials ⚠️
src/fides/api/schemas/consentable_item.py 88.88% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5190      +/-   ##
==========================================
+ Coverage   80.09%   86.45%   +6.35%     
==========================================
  Files         360      360              
  Lines       22587    22598      +11     
  Branches     2998     3000       +2     
==========================================
+ Hits        18092    19538    +1446     
+ Misses       3992     2520    -1472     
- Partials      503      540      +37     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@eastandwestwind eastandwestwind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean work! Thanks for adding the tests too ⭐

@galvana galvana merged commit 1d6aa2c into main Aug 14, 2024
14 checks passed
@galvana galvana deleted the PROD-2346-changes-to-support-consent-signals branch August 14, 2024 02:19
Copy link

cypress bot commented Aug 14, 2024



Test summary

4 0 0 0


Run details

Project fides
Status Passed
Commit 1d6aa2c
Started Aug 14, 2024 2:31 AM
Ended Aug 14, 2024 2:32 AM
Duration 00:36 💡
OS Linux Ubuntu -
Browser Electron 106

View run in Cypress Cloud ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants