-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating SSO types + minor fixes #5183
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Test summaryRun details
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for adding comments for the CR, it was very helpful. Everything here looks good. I tested with the corresponding fidesplus branch. Editing, deleting, everything working as expected. Approved!
I added 1 commit to update the flag name from open id to "SSO Authentication Providers (OpenID)" to be consistent with the name we're using for the users.
Test summaryRun details
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud |
Description Of Changes
Fixing the SSO providers form after some changes in the backend started causing type issues.
Code Changes
admin-ui
usingturbo run openapi:generate
SSO provider
consistently across the SSO provider flowSteps to Confirm
Pre-Merge Checklist
CHANGELOG.md