Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating SSO types + minor fixes #5183

Merged
merged 8 commits into from
Aug 13, 2024
Merged

Updating SSO types + minor fixes #5183

merged 8 commits into from
Aug 13, 2024

Conversation

galvana
Copy link
Contributor

@galvana galvana commented Aug 13, 2024

Description Of Changes

Fixing the SSO providers form after some changes in the backend started causing type issues.

Code Changes

  • Updated types in the admin-ui using turbo run openapi:generate
  • Updated messages to use SSO provider consistently across the SSO provider flow

Steps to Confirm

  • Tests should pass

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Issue Requirements are Met
  • Update CHANGELOG.md

Copy link

vercel bot commented Aug 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fides-plus-nightly ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 13, 2024 5:05pm

Copy link

cypress bot commented Aug 13, 2024



Test summary

4 0 0 0


Run details

Project fides
Status Passed
Commit 5979705744 ℹ️
Started Aug 13, 2024 5:14 PM
Ended Aug 13, 2024 5:14 PM
Duration 00:37 💡
OS Linux Ubuntu -
Browser Electron 106

View run in Cypress Cloud ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud

Copy link
Contributor

@lucanovera lucanovera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for adding comments for the CR, it was very helpful. Everything here looks good. I tested with the corresponding fidesplus branch. Editing, deleting, everything working as expected. Approved!
I added 1 commit to update the flag name from open id to "SSO Authentication Providers (OpenID)" to be consistent with the name we're using for the users.

@galvana galvana merged commit 89345c0 into main Aug 13, 2024
10 of 11 checks passed
@galvana galvana deleted the fixing-sso-providers branch August 13, 2024 17:00
Copy link

cypress bot commented Aug 13, 2024



Test summary

4 0 0 0


Run details

Project fides
Status Passed
Commit 89345c0
Started Aug 13, 2024 5:14 PM
Ended Aug 13, 2024 5:15 PM
Duration 00:36 💡
OS Linux Ubuntu -
Browser Electron 106

View run in Cypress Cloud ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants