Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade ESLint configs to modules #5176

Merged
merged 3 commits into from
Aug 13, 2024
Merged

Upgrade ESLint configs to modules #5176

merged 3 commits into from
Aug 13, 2024

Conversation

gilluminate
Copy link
Contributor

@gilluminate gilluminate commented Aug 9, 2024

Description Of Changes

fixes some configuration issues with ESLint that was problematic when opening a file from more than one client directory (eg. a file from admin-ui and a file from fides-js)

Code Changes

  • upgrade all ESLint config files to more modern module (still not fully converted to new "flat" config format because that will require a lot more effort)
  • Add /client root directory to VS Code's working directory to avoid errors with any root files there
  • minor fixes

Steps to Confirm

  • You should no longer see errors about eslintconfig and tsconfig and missing files
  • Tests passing below should also help confirm

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Update CHANGELOG.md

Copy link

vercel bot commented Aug 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
fides-plus-nightly ⬜️ Ignored (Inspect) Visit Preview Aug 9, 2024 10:26pm

Copy link

cypress bot commented Aug 9, 2024



Test summary

4 0 0 0


Run details

Project fides
Status Passed
Commit cd2a27e07a ℹ️
Started Aug 9, 2024 10:38 PM
Ended Aug 9, 2024 10:39 PM
Duration 00:36 💡
OS Linux Ubuntu -
Browser Electron 106

View run in Cypress Cloud ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud

@gilluminate gilluminate merged commit dbb27b7 into main Aug 13, 2024
13 checks passed
@gilluminate gilluminate deleted the fix/eslint branch August 13, 2024 16:43
Copy link

cypress bot commented Aug 13, 2024



Test summary

4 0 0 0


Run details

Project fides
Status Passed
Commit dbb27b7
Started Aug 13, 2024 4:56 PM
Ended Aug 13, 2024 4:56 PM
Duration 00:36 💡
OS Linux Ubuntu -
Browser Electron 106

View run in Cypress Cloud ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants