Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BigQuery nested field UI #5175

Merged
merged 21 commits into from
Aug 14, 2024
Merged

BigQuery nested field UI #5175

merged 21 commits into from
Aug 14, 2024

Conversation

jpople
Copy link
Contributor

@jpople jpople commented Aug 9, 2024

Closes PROD-2353

Description Of Changes

Adds UI support for nested fields in BigQuery.

Visual changes to page headers and breadcrumbs:

Old:

Screenshot 2024-08-09 at 14 59 36

New:

Screenshot 2024-08-09 at 14 58 48

Resources in result tables with children that can be "clicked into" now have semibold name:

Screenshot 2024-08-09 at 15 01 05

Result tables now support "clicking into" nested fields and viewing subfields:

Screenshot 2024-08-09 at 15 02 52

Code Changes

  • Change breadcrumb component on D&D results pages to feature icons for what "level" the result is
  • Change FidesTable to allow onRowClick to be optional on a per-row basis within a table
  • Regenerate OpenAPI types

Steps to Confirm

Against Fidesplus backend on branch PROD-2352_support-nested-fields-BE (make sure you run the backend with nox -s "build(fidesplus)" "dev(fidesplus)" so the classifier can work):

  • Set up a monitor for a BigQuery integration that has nested fields
  • Run the monitor
  • View results in detection tables
  • Should be able to click through to nested fields and see subfields; non-nested fields should be normal font weight and not be clickable
  • Monitor a table with nested fields
  • View results in discovery tables after classification is finished
  • Should be able to click through to nested fields and see subfields; non-nested fields should be normal font weight and not be clickable

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Issue Requirements are Met
  • Relevant Follow-Up Issues Created
  • Update CHANGELOG.md

Copy link

vercel bot commented Aug 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fides-plus-nightly ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 14, 2024 3:30pm

Copy link
Contributor

@lucanovera lucanovera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the UI and it works correctly, I was able to navigate up and down nested fields with no problems. The code looks good as well. I will leave you the approval and you can merge once the CI issues are resolved.

Captura de pantalla 2024-08-12 a la(s) 3 31 55 p  m

Copy link

cypress bot commented Aug 12, 2024



Test summary

4 0 0 0


Run details

Project fides
Status Passed
Commit 1be612ed75 ℹ️
Started Aug 14, 2024 3:40 PM
Ended Aug 14, 2024 3:41 PM
Duration 00:36 💡
OS Linux Ubuntu -
Browser Electron 106

View run in Cypress Cloud ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud

@jpople jpople merged commit 8325258 into main Aug 14, 2024
13 checks passed
@jpople jpople deleted the jpople/prod-2353/bq-nested-fields branch August 14, 2024 15:43
Copy link

cypress bot commented Aug 14, 2024



Test summary

4 0 0 0


Run details

Project fides
Status Passed
Commit 8325258
Started Aug 14, 2024 3:55 PM
Ended Aug 14, 2024 3:56 PM
Duration 00:37 💡
OS Linux Ubuntu -
Browser Electron 106

View run in Cypress Cloud ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants