Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating Yotpo Reviews to use email or phone number instead of external IDs #5169

Merged
merged 8 commits into from
Aug 14, 2024

Conversation

galvana
Copy link
Contributor

@galvana galvana commented Aug 8, 2024

Closes PROD-2527

Description Of Changes

Updated the Yotpo Reviews integration to support email or phone number identities for the customer lookup. We also added the yotpo_ugc field to the dataset (Yotpo User Generated Content aka Reviews). This does not return all of the reviews, just a summary of various aggregated properties.

Code Changes

  • Updated config, dataset, and tests

Steps to Confirm

  • Run tests

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Issue Requirements are Met
  • Update CHANGELOG.md

Removing External ID in favour of Email
Adding the Yotpo UGC  Fields, and the Channel Fields
Copy link

vercel bot commented Aug 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
fides-plus-nightly ⬜️ Ignored (Inspect) Visit Preview Aug 14, 2024 5:46pm

@galvana galvana changed the title Updating yotpo reviews using email Updating Yotpo Reviews to use email instead of external IDs Aug 8, 2024
Copy link

cypress bot commented Aug 8, 2024



Test summary

4 0 0 0


Run details

Project fides
Status Passed
Commit f33ed32ee7 ℹ️
Started Aug 14, 2024 5:58 PM
Ended Aug 14, 2024 5:59 PM
Duration 00:37 💡
OS Linux Ubuntu -
Browser Electron 106

View run in Cypress Cloud ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud

Copy link

codecov bot commented Aug 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.55%. Comparing base (1d6aa2c) to head (217f29a).
Report is 9 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5169      +/-   ##
==========================================
+ Coverage   86.46%   86.55%   +0.09%     
==========================================
  Files         360      362       +2     
  Lines       22598    22727     +129     
  Branches     3000     3026      +26     
==========================================
+ Hits        19539    19671     +132     
+ Misses       2519     2511       -8     
- Partials      540      545       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@galvana galvana added the run unsafe ci checks Runs fides-related CI checks that require sensitive credentials label Aug 9, 2024
@galvana galvana changed the title Updating Yotpo Reviews to use email instead of external IDs Updating Yotpo Reviews to use email or phone number instead of external IDs Aug 9, 2024
@galvana galvana marked this pull request as ready for review August 9, 2024 23:42
@galvana galvana requested a review from a team as a code owner August 9, 2024 23:42
Copy link
Contributor

@RobertKeyser RobertKeyser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for including the reviews!

@galvana galvana merged commit 89af8dc into main Aug 14, 2024
14 checks passed
@galvana galvana deleted the UpdatingYotpoReviews_UsingEmail branch August 14, 2024 17:46
Copy link

cypress bot commented Aug 14, 2024



Test summary

4 0 0 0


Run details

Project fides
Status Passed
Commit 89af8dc
Started Aug 14, 2024 5:59 PM
Ended Aug 14, 2024 5:59 PM
Duration 00:36 💡
OS Linux Ubuntu -
Browser Electron 106

View run in Cypress Cloud ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run unsafe ci checks Runs fides-related CI checks that require sensitive credentials
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants