-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix TCF overlay issues on mobile sized screens #5157
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
0478536
to
887702b
Compare
@@ -537,7 +537,7 @@ div#fides-banner-inner .fides-privacy-policy { | |||
} | |||
|
|||
div#fides-banner-inner .fides-privacy-policy, | |||
button.fides-banner-button.fides-manage-preferences-button, | |||
button.fides-banner-button.fides-banner-button-tertiary, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixes the Manage Preferences button size on mobile
@media screen and (max-width: 768px) { | ||
.fides-tcf-banner-container #fides-banner { | ||
padding: 24px; | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since the TCF specific styles are below the mobile media query styles, the mobile adjustment was being overridden and not being applied. This fix does the same thing, but specific to TCF padding.
Test summaryRun details
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Manually tested TCF, non-TCF, and acknowledge banners. All are looking great!
Test summaryRun details
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud |
Description Of Changes
Fixes a newly introduced issue with overlay banner layout, specifically with the positioning of the buttons.
Includes some added polish for noticed issues while testing the mobile version.
Code Changes
Steps to Confirm
Pre-Merge Checklist
CHANGELOG.md