Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TCF overlay issues on mobile sized screens #5157

Merged
merged 3 commits into from
Aug 5, 2024

Conversation

gilluminate
Copy link
Contributor

@gilluminate gilluminate commented Aug 5, 2024

Description Of Changes

Fixes a newly introduced issue with overlay banner layout, specifically with the positioning of the buttons.

Includes some added polish for noticed issues while testing the mobile version.

Code Changes

  • Reverts and HTML ordering change made in a recent commit
  • Fixes some styling issues relating to the banner buttons and layout.

Steps to Confirm

  • Visit TCF enabled experience in the demo site (eg. http://localhost:3001/fides-js-demo.html?geolocation=eea)
  • Verify user can scroll the content but the buttons remain sticky at the bottom
  • Verify the "Manage Preferences" button has similar size as other buttons
  • Verify order of buttons to ensure Privacy Policy link appears below Manage Preferences and above language switcher

TCF banner overlay on mobile sized screen

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Update CHANGELOG.md

Copy link

vercel bot commented Aug 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
fides-plus-nightly ⬜️ Ignored (Inspect) Visit Preview Aug 5, 2024 11:15pm

@@ -537,7 +537,7 @@ div#fides-banner-inner .fides-privacy-policy {
}

div#fides-banner-inner .fides-privacy-policy,
button.fides-banner-button.fides-manage-preferences-button,
button.fides-banner-button.fides-banner-button-tertiary,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixes the Manage Preferences button size on mobile

Comment on lines +1127 to +1131
@media screen and (max-width: 768px) {
.fides-tcf-banner-container #fides-banner {
padding: 24px;
}
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since the TCF specific styles are below the mobile media query styles, the mobile adjustment was being overridden and not being applied. This fix does the same thing, but specific to TCF padding.

Copy link

cypress bot commented Aug 5, 2024



Test summary

4 0 0 0


Run details

Project fides
Status Passed
Commit 1709a27e44 ℹ️
Started Aug 5, 2024 11:27 PM
Ended Aug 5, 2024 11:27 PM
Duration 00:37 💡
OS Linux Ubuntu -
Browser Electron 106

View run in Cypress Cloud ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud

@eastandwestwind eastandwestwind self-requested a review August 5, 2024 23:17
Copy link
Contributor

@eastandwestwind eastandwestwind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manually tested TCF, non-TCF, and acknowledge banners. All are looking great!

@gilluminate gilluminate merged commit b29cbf5 into main Aug 5, 2024
13 checks passed
@gilluminate gilluminate deleted the fix/mobile-tcf-overlay branch August 5, 2024 23:47
Copy link

cypress bot commented Aug 6, 2024



Test summary

4 0 0 0


Run details

Project fides
Status Passed
Commit b29cbf5
Started Aug 5, 2024 11:59 PM
Ended Aug 6, 2024 12:00 AM
Duration 00:37 💡
OS Linux Ubuntu -
Browser Electron 106

View run in Cypress Cloud ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants