-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PROD-1899 Move-admin-UI-away-from-using-unpaginated-system-and-dataset-APIs-where-possible #5135
PROD-1899 Move-admin-UI-away-from-using-unpaginated-system-and-dataset-APIs-where-possible #5135
Conversation
…systems-page-with-Table-view
…systems-page-with-Table-view
…b.com:ethyca/fides into PROD-1899-Move-admin-UI-away-from-using-unpaginated-system-and-dataset-APIs-where-possible
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
…ySystemis removed
…redux states (the page was already disabled)
Test summaryRun details
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud |
… search param for paginated endpoint
…min-UI-away-from-using-unpaginated-system-and-dataset-APIs-where-possible
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good!
✅ Doesn't query all systems on loading homepage
✅ Shows side panel in data lineage view
✅ Correctly checks duplicate system names
Aside from one text fix, looks all good to me.
Co-authored-by: jpople <[email protected]>
…min-UI-away-from-using-unpaginated-system-and-dataset-APIs-where-possible
…tem-and-dataset-APIs-where-possible' of github.com:ethyca/fides into PROD-1899-Move-admin-UI-away-from-using-unpaginated-system-and-dataset-APIs-where-possible
Test summaryRun details
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud |
Description Of Changes
Remove uses of unpaginated systems and dataset APIs where possible.
Code Changes
Steps to Confirm
Open browser dev tools & go to network tab
Log in to admin-ui
Go do Data Lineage and Click on a system, the sidepanel should display as usual
Go to Add System > Manual. Type a name for an existing system and check that the validation tells you the system already exists.
Pre-Merge Checklist
CHANGELOG.md