Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PROD-2332 dataset page to use the new table component #5130

Merged
merged 12 commits into from
Jul 31, 2024

Conversation

lucanovera
Copy link
Contributor

@lucanovera lucanovera commented Jul 26, 2024

Description Of Changes

Refactor dataset page to use new table component, the new paginated endpoint and support search.

Code Changes

  • Add new table to dataset page
  • Add new getDataset endpoint to slice with pagination & search param support
  • Remove old dataset table
  • Add search bar

Screenshot

Captura de pantalla 2024-07-31 a la(s) 3 45 58 p  m

Steps to Confirm

  • Log in to admin-ui. Open dev tools and network tab.
  • Go to Manage Dataset
  • Check that the table displays the datasets correctly
  • Check that clicking on a table result takes you to the dataset detail page
  • Check in the network tab that the paginated endpoint is being used with the exclude_saas_datasets param set to true

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Issue Requirements are Met
  • Update CHANGELOG.md

Copy link

vercel bot commented Jul 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fides-plus-nightly ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 31, 2024 7:15pm

Copy link

cypress bot commented Jul 26, 2024



Test summary

4 0 0 0


Run details

Project fides
Status Passed
Commit 8c93d96546 ℹ️
Started Jul 31, 2024 7:21 PM
Ended Jul 31, 2024 7:22 PM
Duration 00:33 💡
OS Linux Ubuntu -
Browser Electron 106

View run in Cypress Cloud ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud

const datasetApi = baseApi.injectEndpoints({
endpoints: (build) => ({
getDatasets: build.query<
Page_Dataset_,
PaginationQueryParams & SearchQueryParams & DatasetFiltersQueryParams
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

@lucanovera lucanovera merged commit e85b164 into main Jul 31, 2024
13 checks passed
@lucanovera lucanovera deleted the PROD-2332-Dataset-page-to-use-the-new-table-component branch July 31, 2024 19:47
Copy link

cypress bot commented Jul 31, 2024



Test summary

4 0 0 0


Run details

Project fides
Status Passed
Commit e85b164
Started Jul 31, 2024 7:59 PM
Ended Jul 31, 2024 8:00 PM
Duration 00:36 💡
OS Linux Ubuntu -
Browser Electron 106

View run in Cypress Cloud ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants