Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .syncignore to ignore unnecessary file syncs to volume #5104

Merged
merged 2 commits into from
Jul 19, 2024

Conversation

SteveDMurphy
Copy link
Contributor

@SteveDMurphy SteveDMurphy commented Jul 18, 2024

Closes n/a

Description Of Changes

This is a minor dev qol change to reduce build times when dropping volumes. It was noticed that we were moving the entire .nox directory over causing >7GB of data transfer

This will reduce it to <1GB (more could likely be added but this is a good start anyway)

Before:
Screenshot 2024-07-18 at 9 42 37 PM

After:
Screenshot 2024-07-18 at 9 46 33 PM

Code Changes

  • Add a .syncignore file to the root
  • Copy some directories over from .dockerignore

Steps to Confirm

  • Measure the sizes to upload
  • Validate the UI isn't affected when running nox -s dev

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Documentation:
    • documentation complete, PR opened in fidesdocs
    • documentation issue created in fidesdocs
    • if there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
  • Issue Requirements are Met
  • Relevant Follow-Up Issues Created
  • Update CHANGELOG.md
  • For API changes, the Postman collection has been updated
  • If there are any database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!

Copy link

vercel bot commented Jul 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
fides-plus-nightly ⬜️ Ignored (Inspect) Visit Preview Jul 18, 2024 8:55pm

@SteveDMurphy SteveDMurphy force-pushed the SteveDMurphy-reduce-docker-vol-size branch from d74eaf0 to 4394d1c Compare July 18, 2024 20:55
Copy link

cypress bot commented Jul 18, 2024

Passing run #9012 ↗︎

0 4 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge 4394d1c into 8113867...
Project: fides Commit: 77ef29d30e ℹ️
Status: Passed Duration: 00:35 💡
Started: Jul 18, 2024 9:06 PM Ended: Jul 18, 2024 9:06 PM

Review all test suite changes for PR #5104 ↗︎

Copy link

codecov bot commented Jul 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.42%. Comparing base (8113867) to head (4394d1c).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5104   +/-   ##
=======================================
  Coverage   86.42%   86.42%           
=======================================
  Files         357      357           
  Lines       22345    22345           
  Branches     2954     2954           
=======================================
  Hits        19312    19312           
  Misses       2516     2516           
  Partials      517      517           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SteveDMurphy SteveDMurphy marked this pull request as ready for review July 18, 2024 22:15
@SteveDMurphy SteveDMurphy self-assigned this Jul 18, 2024
Copy link
Contributor

@pattisdr pattisdr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow 7+ GB good find. change makes sense to me.

@SteveDMurphy SteveDMurphy merged commit 45ed408 into main Jul 19, 2024
45 checks passed
@SteveDMurphy SteveDMurphy deleted the SteveDMurphy-reduce-docker-vol-size branch July 19, 2024 11:17
Copy link

cypress bot commented Jul 19, 2024

Passing run #9026 ↗︎

0 4 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Add .syncignore to ignore unnecessary file syncs to volume (#5104)
Project: fides Commit: 45ed4082e1
Status: Passed Duration: 00:35 💡
Started: Jul 19, 2024 11:28 AM Ended: Jul 19, 2024 11:28 AM

Review all test suite changes for PR #5104 ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants