Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PROD-2307 Add notice to messaging page #5077

Merged
merged 6 commits into from
Jul 12, 2024

Conversation

lucanovera
Copy link
Contributor

@lucanovera lucanovera commented Jul 10, 2024

Description Of Changes

Add a new notice to the messaging page when there are properties without any messaging templates configured.

Code Changes

  • Added closing functionality to InfoBox
  • Added call to properties endpoint to check associated templates
  • Added notice using InfoBox
  • Generate a unique id for the notice and store it in localStorage when user dismisses

Screenshot

Captura de pantalla 2024-07-10 a la(s) 11 02 31 a  m

Steps to Confirm

  • Log in to admin-ui
  • Go to Settings > Properties and add a new property
  • Go to Settings > Messaging
  • See that there should be a notice about having a property without any messaging templates
  • Dismiss the notice and reload the page. The notice should not appear anymore.
  • Go to Settings > Properties and add a new property
  • Go to Settings > Messaging. The notice should appear again since the properties have changed.

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Issue Requirements are Met
  • Update CHANGELOG.md

Copy link

vercel bot commented Jul 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fides-plus-nightly ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 12, 2024 2:19pm

Copy link

cypress bot commented Jul 10, 2024

Passing run #8868 ↗︎

0 4 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge cfef8f5 into ba5a494...
Project: fides Commit: e95c9baf6e ℹ️
Status: Passed Duration: 00:35 💡
Started: Jul 12, 2024 2:28 PM Ended: Jul 12, 2024 2:28 PM

Review all test suite changes for PR #5077 ↗︎

@lucanovera lucanovera changed the title Draft: PROD-2307 Add notice to messaging page PROD-2307 Add notice to messaging page Jul 11, 2024
Copy link
Contributor

@eastandwestwind eastandwestwind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested manually and worked great for me. Just a small typo, otherwise good to go.

@lucanovera lucanovera merged commit 8dad9bb into main Jul 12, 2024
10 of 11 checks passed
@lucanovera lucanovera deleted the PROD-2307-add-notice-to-messaging-page branch July 12, 2024 14:18
Copy link

cypress bot commented Jul 12, 2024

Passing run #8869 ↗︎

0 4 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

PROD-2307 Add notice to messaging page (#5077)
Project: fides Commit: 8dad9bb4f5
Status: Passed Duration: 00:34 💡
Started: Jul 12, 2024 2:29 PM Ended: Jul 12, 2024 2:29 PM

Review all test suite changes for PR #5077 ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants