PROD-2083: fix for mysql reserved word escaping #5072
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mysql-reserved-word-escaping
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
Passing run #8850 ↗︎
Details:
Review all test suite changes for PR #5072 ↗︎ |
||||||||||||||||||||
adamsachs
reviewed
Jul 10, 2024
| @@ -364,7 +364,7 @@ def get_formatted_query_string( | |||
| clauses: List[str], | |||
| ) -> str: | |||
| """Returns an SQL query string.""" | |||
| return f"SELECT {field_list} FROM {self.node.collection.name} WHERE {' OR '.join(clauses)}" | |||
| return f"SELECT {field_list} FROM `{self.node.collection.name}` WHERE {' OR '.join(clauses)}" | |||
There was a problem hiding this comment.
early drive-by review - i think you found the right spot for this! 🎊
thingscouldbeworse
changed the title
…aping table names
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5072 +/- ##
=======================================
Coverage 86.41% 86.42%
=======================================
Files 356 356
Lines 22171 22181 +10
Branches 2913 2913
=======================================
+ Hits 19159 19169 +10
Misses 2497 2497
Partials 515 515 ☔ View full report in Codecov by Sentry. |
erosselli
reviewed
Jul 11, 2024
erosselli
approved these changes
Jul 11, 2024
thingscouldbeworse
deleted the
PROD-2083_fixtures-for-mysql-reserved-word-escaping
branch
Passing run #8851 ↗︎
Details:
Review all test suite changes for PR #5072 ↗︎ |
||||||||||||||||||||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes # PROD-2083
Description Of Changes
Escapes table names for mysql/postgresql, mysql in backticks and postgresql in double quotes. Prevents errors on collections with tables named with reserved keywords.
Code Changes
add a QueryConfig for mysql and postgresql which uses backticks or double quotes depending on which dialect
Steps to Confirm
Leadtable has been added to the mysqlPre-Merge Checklist
CHANGELOG.mdmaindowngrade()migration is correct and works