Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Amplitude integration #5063

Merged
merged 3 commits into from
Jul 5, 2024
Merged

Update Amplitude integration #5063

merged 3 commits into from
Jul 5, 2024

Conversation

galvana
Copy link
Contributor

@galvana galvana commented Jul 3, 2024

Description Of Changes

Updates the Amplitude dataset and test assertions to fix the External-SaaS-Connectors errors

Steps to Confirm

  • The External-SaaS-Connectors tests should pass

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Issue Requirements are Met
  • Update CHANGELOG.md

Copy link

vercel bot commented Jul 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fides-plus-nightly ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 5, 2024 4:34pm

@galvana galvana added the run unsafe ci checks Runs fides-related CI checks that require sensitive credentials label Jul 3, 2024
Copy link

cypress bot commented Jul 3, 2024

Passing run #8784 ↗︎

0 4 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge 394b47a into 6710d38...
Project: fides Commit: 16cc6e2241 ℹ️
Status: Passed Duration: 00:45 💡
Started: Jul 5, 2024 4:43 PM Ended: Jul 5, 2024 4:44 PM

Review all test suite changes for PR #5063 ↗︎

Copy link

codecov bot commented Jul 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.07%. Comparing base (f3fa422) to head (a694736).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5063   +/-   ##
=======================================
  Coverage   85.07%   85.07%           
=======================================
  Files         356      356           
  Lines       22171    22171           
  Branches     2913     2913           
=======================================
  Hits        18862    18862           
  Misses       2778     2778           
  Partials      531      531           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@galvana galvana marked this pull request as ready for review July 5, 2024 15:30
@galvana galvana requested a review from a team as a code owner July 5, 2024 15:30
Copy link
Contributor

@Kelsey-Ethyca Kelsey-Ethyca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦖

@galvana galvana merged commit d265cb2 into main Jul 5, 2024
13 of 14 checks passed
@galvana galvana deleted the update-amplitude-integration branch July 5, 2024 16:32
Copy link

cypress bot commented Jul 5, 2024

Passing run #8783 ↗︎

0 4 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Update Amplitude integration (#5063)
Project: fides Commit: d265cb2688
Status: Passed Duration: 00:41 💡
Started: Jul 5, 2024 4:43 PM Ended: Jul 5, 2024 4:44 PM

Review all test suite changes for PR #5063 ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run unsafe ci checks Runs fides-related CI checks that require sensitive credentials
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants