Skip database selection step when monitors would have no databases #5056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
Passing run #8745 ↗︎
Details:
Review all test suite changes for PR #5056 ↗︎ |
|||||||||||||||
lucanovera
approved these changes
Jul 3, 2024
| @@ -81,7 +87,11 @@ const ConfigureMonitorForm = ({ | |||
| single_dataset: false, | |||
| }; | |||
| } | |||
| onAdvance(payload); | |||
| if (databasesAvailable) { | |||
| const [putMonitorMutationTrigger, { isLoading: isSubmitting }] = | ||
| usePutDiscoveryMonitorMutation(); | ||
|
|
||
| const { data: databases } = useGetDatabasesByConnectionQuery({ |
There was a problem hiding this comment.
Perfect. Having the data fetching higher up in the component hierarchy is very useful.
Passing run #8746 ↗︎
Details:
Review all test suite changes for PR #5056 ↗︎ |
|||||||||||||||
andres-torres-marroquin
pushed a commit
that referenced
this pull request
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Of Changes
In discovery monitor configuration UI, changes form to submit immediately instead of advancing to blank project selection UI when there are no projects associated with the integration.
Code Changes
Steps to Confirm
Pre-Merge Checklist
CHANGELOG.md