Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Shopify dataset to remove blog authors from the access package #5043

Merged
merged 5 commits into from
Jul 29, 2024

Conversation

SteveDMurphy
Copy link
Contributor

@SteveDMurphy SteveDMurphy commented Jul 1, 2024

Closes FIDES#869

Description Of Changes

In the Shopify Integration we currently have the author information set as a personal data category. This changes that as an immediate stopgap.

We should probably do something further to improve the situation where the blog author is requesting their information but that may be a follow on effort

Code Changes

  • Update the Shopify Dataset

Steps to Confirm

  • Validate no blog author is returned when one exists (tested externally)

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Documentation:
    • documentation complete, PR opened in fidesdocs
    • documentation issue created in fidesdocs
    • if there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
  • Issue Requirements are Met
  • Relevant Follow-Up Issues Created
  • Update CHANGELOG.md
  • For API changes, the Postman collection has been updated
  • If there are any database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!

Copy link

vercel bot commented Jul 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fides-plus-nightly ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 24, 2024 10:41am

@SteveDMurphy SteveDMurphy self-assigned this Jul 1, 2024
Copy link

cypress bot commented Jul 1, 2024

Passing run #9117 ↗︎

0 4 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge 1af71ae into 805aa66...
Project: fides Commit: 3ae5eaa7be ℹ️
Status: Passed Duration: 00:34 💡
Started: Jul 24, 2024 10:50 AM Ended: Jul 24, 2024 10:50 AM

Review all test suite changes for PR #5043 ↗︎

Copy link

codecov bot commented Jul 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.54%. Comparing base (805aa66) to head (1af71ae).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5043      +/-   ##
==========================================
- Coverage   86.54%   86.54%   -0.01%     
==========================================
  Files         357      357              
  Lines       22345    22345              
  Branches     2954     2954              
==========================================
- Hits        19339    19338       -1     
- Misses       2482     2483       +1     
  Partials      524      524              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SteveDMurphy SteveDMurphy requested a review from galvana July 19, 2024 11:21
@SteveDMurphy SteveDMurphy marked this pull request as ready for review July 19, 2024 11:21
@SteveDMurphy SteveDMurphy requested a review from a team as a code owner July 19, 2024 11:21
@SteveDMurphy SteveDMurphy merged commit bf527dd into main Jul 29, 2024
44 of 45 checks passed
@SteveDMurphy SteveDMurphy deleted the SteveDMurphy-fides-869-blog branch July 29, 2024 16:20
Copy link

cypress bot commented Jul 29, 2024



Test summary

4 0 0 0


Run details

Project fides
Status Passed
Commit bf527dd
Started Jul 29, 2024 4:32 PM
Ended Jul 29, 2024 4:33 PM
Duration 00:36 💡
OS Linux Ubuntu -
Browser Electron 106

View run in Cypress Cloud ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants