Add ssl prefer to remaining redshift areas, increase timeout (maybe) #4981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Passing run #8492 ↗︎
Details:
Review all test suite changes for PR #4981 ↗︎ |
||||||||||||||||||||
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4981 +/- ##
==========================================
- Coverage 86.56% 86.54% -0.02%
==========================================
Files 352 352
Lines 21877 21882 +5
Branches 2884 2885 +1
==========================================
Hits 18938 18938
- Misses 2433 2438 +5
Partials 506 506 ☔ View full report in Codecov by Sentry. |
…s-699-redshift-generate-ssl-errors-contd
SteveDMurphy
commented
Jun 20, 2024
| ) | ||
| if "redshift" in connection_string: | ||
| connect_args["sslmode"] = "prefer" | ||
| connect_args["connect_timeout"] = 60 |
There was a problem hiding this comment.
The Redshift datasets from Axios were taking forever to load, this number let it run long enough to respond with all of the dataset information
NevilleS
approved these changes
Jun 21, 2024
SteveDMurphy
deleted the
SteveDMurphy-fides-699-redshift-generate-ssl-errors-contd
branch
Passing run #8496 ↗︎
Details:
Review all test suite changes for PR #4981 ↗︎ |
||||||||||||||||||||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes FIDES-699, follow up to #4849
Description Of Changes
This PR should handle the reamining areas where Redshift can fail to connect successfully due to ssl or timeout errors
Code Changes
Steps to Confirm
Pre-Merge Checklist
CHANGELOG.md