Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix and optimize Database Icons used in Datamap #4969

Merged
merged 2 commits into from
Jun 10, 2024

Conversation

gilluminate
Copy link
Contributor

@gilluminate gilluminate commented Jun 10, 2024

Closes PROD-957

Description Of Changes

Database icons weren't showing up in Firefox. There was an extra display: none style that wasn't respected by other browsers causing the issue.

Code Changes

  • Remove extraneous display: none style from the DatabaseIcon.svg file.
  • Run both DatabaseIcon.svg and SelectedDatabaseIcon.svg files through svgo to cut their file sizes in half.
  • Added header to each, which is suggested by the Cryptoscape.sj docs to include in all SVGs used.

Steps to Confirm

  • visit Fides Admin UI Data Lineage page using the Firefox browser /datamap
  • Observe that the database icon is now showing up.

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Issue Requirements are Met
  • Update CHANGELOG.md

Copy link

vercel bot commented Jun 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
fides-plus-nightly ⬜️ Ignored (Inspect) Visit Preview Jun 10, 2024 8:25pm

@gilluminate gilluminate force-pushed the gill/PROD-957_unity-system-icons-not branch from 8853f6e to 1ebf652 Compare June 10, 2024 20:21
Copy link

cypress bot commented Jun 10, 2024

Passing run #8223 ↗︎

0 4 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge e96f46a into 989d850...
Project: fides Commit: 7b4ee8be10 ℹ️
Status: Passed Duration: 00:36 💡
Started: Jun 10, 2024 8:35 PM Ended: Jun 10, 2024 8:36 PM

Review all test suite changes for PR #4969 ↗︎

Copy link
Contributor

@NevilleS NevilleS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@gilluminate gilluminate marked this pull request as ready for review June 10, 2024 21:04
@gilluminate gilluminate merged commit 452a4ca into main Jun 10, 2024
13 checks passed
@gilluminate gilluminate deleted the gill/PROD-957_unity-system-icons-not branch June 10, 2024 21:04
Copy link

cypress bot commented Jun 10, 2024

Passing run #8226 ↗︎

0 4 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

fix and optimize Database Icons used in Datamap (#4969)
Project: fides Commit: 452a4ca08a
Status: Passed Duration: 00:33 💡
Started: Jun 10, 2024 9:16 PM Ended: Jun 10, 2024 9:17 PM

Review all test suite changes for PR #4969 ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants