Add new option for disabling notices-served api in FidesJS #4965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
gilluminate
force-pushed
the
gill/PROD-2160_fides-js-configuration-to
branch
2 times, most recently
from
03c9660
to
5f6b4fd
Compare
Passing run #8209 ↗︎
Details:
Review all test suite changes for PR #4965 ↗︎ |
||||||||||||||||||||
gilluminate
force-pushed
the
gill/PROD-2160_fides-js-configuration-to
branch
from
d52e6e7
to
245e50d
Compare
gilluminate
changed the title
eastandwestwind
approved these changes
Jun 10, 2024
Passing run #8216 ↗︎
Details:
Review all test suite changes for PR #4965 ↗︎ |
||||||||||||||||||||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes PROD-2160
Description Of Changes
Adds a new configuration option for Fides.js that disables the saving of
notices-served, so this request can be turned off independently ofprivacy-preferences.Code Changes
fides_disable_notices_served_apias a window or query param optionFIDES_DISABLE_NOTICES_SERVED_APIas an env var optionSteps to Confirm
?fides_disable_notices_served_api=trueas a query paramnotices-servedis not called, butprivacy-preferencesstill is.Pre-Merge Checklist
CHANGELOG.md