When the TC String is included in GPP and Layer 1 is visible, the signalStatus should be "not ready" #4957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
gilluminate
force-pushed
the
PROD-2020-when-the-tc-string-is-included
branch
from
1396afa
to
5a8ec5d
Compare
Passing run #8150 ↗︎
Details:
Review all test suite changes for PR #4957 ↗︎ |
|||||||||||||||
gilluminate
commented
Jun 6, 2024
| @@ -133,18 +133,19 @@ const initializeGppCmpApi = () => { | |||
| makeStub(); | |||
| const cmpApi = new CmpApi(ETHYCA_CMP_ID, CMP_VERSION); | |||
| cmpApi.setCmpStatus(CmpStatus.LOADED); | |||
| // If consent does not need to be resurfaced, then we can set the signal to Ready here | |||
There was a problem hiding this comment.
this was redundant with the notes starting on 141
Comment on lines
+204
to
+206
| sectionsChanged.forEach((section) => { | ||
| cmpApi.fireSectionChange(section.name); | ||
| }); |
There was a problem hiding this comment.
This was confirmed to have been missing from before
lucanovera
approved these changes
Jun 6, 2024
| window.addEventListener("FidesInitialized", (event) => { | ||
| // TODO (PROD-1439): re-evaluate if GPP is "cheating" accessing window.Fides instead of using the event details only | ||
| const { experience, saved_consent: savedConsent } = window.Fides; | ||
| const { experience, saved_consent: savedConsent, options } = window.Fides; | ||
| const isTcfEnabled = options.tcfEnabled; |
There was a problem hiding this comment.
I also really like having boolean variables name starting with 'is' or 'has'.
Passing run #8161 ↗︎
Details:
Review all test suite changes for PR #4957 ↗︎ |
|||||||||||||||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes PROD-2020
Description Of Changes
Adding a check for TCF when setting the signal status to ensure it doesn't get set incorrectly. We've been setting it to "ready" too early in TCF enabled environments.
Code Changes
Steps to Confirm
/fides-js-demo.html?geolocation=fr-id)__gpp('ping', ({signalStatus})=>{console.log(signalStatus)})Pre-Merge Checklist
CHANGELOG.md