Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datamap report side panel #4944

Merged
merged 4 commits into from
Jun 4, 2024
Merged

Conversation

gilluminate
Copy link
Contributor

@gilluminate gilluminate commented Jun 3, 2024

Closes PROD-2133

Description Of Changes

Added ability to open system preview side panel from new datamap table, similar to how it works in the old datamap table and re-using that existing slide-out component. Only "System" column cells highlight with a hover state and are clickable.

Code Changes

  • Add new support for clickable cells (in addition to clickable rows) to FidesTable V2 via react-table's meta property
  • Add clickable cell configuration to the new datamap table and have it open the existing drawer component.

Steps to Confirm

  • Add system(s) to Fides using Admin UI at /add-systems
  • Visit the newer datamap report page /reporting/datamap
  • Table will be grouped by system by default
    • Click the system name in the System column
  • Change the table to Group By "Data use"
    • Click the system name in the System column
  • Drawer component should slide out and behave the same as it does on the old datamap table

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Issue Requirements are Met
  • Update CHANGELOG.md

Copy link

vercel bot commented Jun 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fides-plus-nightly ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 4, 2024 8:31pm

Copy link

cypress bot commented Jun 3, 2024

Passing run #8119 ↗︎

0 4 0 0 Flakiness 0

Details:

Merge 63e79ff into 792a041...
Project: fides Commit: 483bce973c ℹ️
Status: Passed Duration: 00:33 💡
Started: Jun 4, 2024 8:40 PM Ended: Jun 4, 2024 8:40 PM

Review all test suite changes for PR #4944 ↗︎

@gilluminate gilluminate changed the title Prod 2133 datamap report side panel Datamap report side panel Jun 3, 2024
@gilluminate gilluminate marked this pull request as ready for review June 3, 2024 20:18
Copy link
Contributor

@eastandwestwind eastandwestwind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manually tested and looks great to me!

Screenshot 2024-06-04 at 6 02 22 PM

@gilluminate gilluminate merged commit ef3d958 into main Jun 4, 2024
13 checks passed
@gilluminate gilluminate deleted the PROD-2133-datamap-report-side-panel branch June 4, 2024 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants