Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding query param key to Privacy Center config #4939

Merged

Conversation

galvana
Copy link
Contributor

@galvana galvana commented May 30, 2024

Closes PROD-2130

Description Of Changes

Updating the server-side definition of the Privacy Center config, specifically the CustomPrivacyRequestField

Code Changes

  • Updated the CustomPrivacyRequestField schema

Steps to Confirm

  • Updated tests

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Documentation:
  • Issue Requirements are Met
  • Update CHANGELOG.md

Copy link

vercel bot commented May 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
fides-plus-nightly ⬜️ Ignored (Inspect) Visit Preview May 31, 2024 10:00pm

@galvana galvana requested a review from lucanovera May 30, 2024 23:16
Copy link

cypress bot commented May 30, 2024

Passing run #8026 ↗︎

0 4 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge 9e9eaa8 into 0ef9822...
Project: fides Commit: 932f9f90a9 ℹ️
Status: Passed Duration: 00:35 💡
Started: May 31, 2024 3:15 PM Ended: May 31, 2024 3:16 PM

Review all test suite changes for PR #4939 ↗︎

Copy link

codecov bot commented May 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.80%. Comparing base (0ef9822) to head (9e9eaa8).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4939   +/-   ##
=======================================
  Coverage   86.79%   86.80%           
=======================================
  Files         347      347           
  Lines       21219    21220    +1     
  Branches     2784     2784           
=======================================
+ Hits        18418    18419    +1     
  Misses       2312     2312           
  Partials      489      489           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@lucanovera lucanovera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good. Thanks. Approved

@galvana galvana merged commit d50f5b3 into main May 31, 2024
14 checks passed
@galvana galvana deleted the PROD-2130-BE-add-query-param-key-to-privacy-center-config branch May 31, 2024 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants