-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Oracle Responsys: Include Profile Extension Tables in DSRs #4937
Conversation
Because the profile extension tables have a fully dynamic schema, we need to treat it as a string in order for it to be included in the DSR package.
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Passing run #8297 ↗︎
Details:
Review all test suite changes for PR #4937 ↗︎ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for taking on this very custom integration 🙏 It's all working as expected so we just mainly need the static checks to pass. The other comments are minor, they won't change the functionality but they're good for the sake of removing unnecessary code or config.
...ides/api/service/saas_request/override_implementations/oracle_responsys_request_overrides.py
Show resolved
Hide resolved
@galvana fixed the static checks. Just a heads up that |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4937 +/- ##
==========================================
- Coverage 86.89% 86.65% -0.24%
==========================================
Files 346 346
Lines 21391 21457 +66
Branches 2822 2841 +19
==========================================
+ Hits 18587 18594 +7
- Misses 2309 2368 +59
Partials 495 495 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fixing the static issues, picking up the extra files is fine 👍
Passing run #8298 ↗︎
Details:
Review all test suite changes for PR #4937 ↗︎ |
Closes FIDES-728
Description Of Changes
Adds profile extension tables (PETs) to DSRs and allows you to limit certain lists and extensions in the config.
Code Changes
Steps to Confirm
Pre-Merge Checklist
CHANGELOG.md
main
downgrade()
migration is correct and works