Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Oracle Responsys: Include Profile Extension Tables in DSRs #4937

Merged
merged 15 commits into from
Jun 13, 2024

Conversation

RobertKeyser
Copy link
Contributor

@RobertKeyser RobertKeyser commented May 30, 2024

Closes FIDES-728

Description Of Changes

Adds profile extension tables (PETs) to DSRs and allows you to limit certain lists and extensions in the config.

Code Changes

  • list your code changes here

Steps to Confirm

  • list any manual steps for reviewers to confirm the changes

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Documentation:
    • documentation complete, PR opened in fidesdocs
    • documentation issue created in fidesdocs
    • if there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
  • Issue Requirements are Met
  • Relevant Follow-Up Issues Created
  • Update CHANGELOG.md
  • For API changes, the Postman collection has been updated
  • If there are any database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!

Because the profile extension tables have a fully dynamic schema, we need to treat it as a string in order for it to be included in the DSR package.
@RobertKeyser RobertKeyser self-assigned this May 30, 2024
Copy link

vercel bot commented May 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fides-plus-nightly ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 13, 2024 3:44pm

Copy link

cypress bot commented May 30, 2024

Passing run #8297 ↗︎

0 4 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge cc6ba46 into 0f4ea85...
Project: fides Commit: 6d74b95dd5 ℹ️
Status: Passed Duration: 00:36 💡
Started: Jun 13, 2024 3:53 PM Ended: Jun 13, 2024 3:53 PM

Review all test suite changes for PR #4937 ↗︎

@RobertKeyser RobertKeyser marked this pull request as ready for review June 7, 2024 19:24
@RobertKeyser RobertKeyser requested a review from a team as a code owner June 7, 2024 19:24
Copy link
Contributor

@galvana galvana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for taking on this very custom integration 🙏 It's all working as expected so we just mainly need the static checks to pass. The other comments are minor, they won't change the functionality but they're good for the sake of removing unnecessary code or config.

@RobertKeyser
Copy link
Contributor Author

@galvana fixed the static checks. Just a heads up that black looks like it picked up a few other files, so I added them too.

Copy link

codecov bot commented Jun 10, 2024

Codecov Report

Attention: Patch coverage is 12.98701% with 67 lines in your changes missing coverage. Please review.

Project coverage is 86.65%. Comparing base (5c8f0b3) to head (26e1bcc).

Files Patch % Lines
...lementations/oracle_responsys_request_overrides.py 12.32% 64 Missing ⚠️
src/fides/connectors/aws.py 0.00% 2 Missing ⚠️
src/fides/core/dataset.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4937      +/-   ##
==========================================
- Coverage   86.89%   86.65%   -0.24%     
==========================================
  Files         346      346              
  Lines       21391    21457      +66     
  Branches     2822     2841      +19     
==========================================
+ Hits        18587    18594       +7     
- Misses       2309     2368      +59     
  Partials      495      495              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@galvana galvana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fixing the static issues, picking up the extra files is fine 👍

@RobertKeyser RobertKeyser merged commit 4fde412 into main Jun 13, 2024
13 of 14 checks passed
Copy link

cypress bot commented Jun 13, 2024

Passing run #8298 ↗︎

0 4 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Oracle Responsys: Include Profile Extension Tables in DSRs (#4937)
Project: fides Commit: 4fde4125b3
Status: Passed Duration: 00:35 💡
Started: Jun 13, 2024 3:53 PM Ended: Jun 13, 2024 3:53 PM

Review all test suite changes for PR #4937 ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants