Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Capitalization in Privacy Center Error Toast #4936

Merged
merged 3 commits into from
May 30, 2024

Conversation

RobertKeyser
Copy link
Contributor

Description Of Changes

This PR fixes some wonky capitalization that's been on my mind for a while.

Original:
Take control of your data

Updated:
image

Code Changes

  • Change toast text from An error occurred while retrieving the Privacy Center Config to An error occurred while retrieving the Privacy Center config

Steps to Confirm

  • list any manual steps for reviewers to confirm the changes

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Documentation:
    • documentation complete, PR opened in fidesdocs
    • documentation issue created in fidesdocs
    • if there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
  • Issue Requirements are Met
  • Relevant Follow-Up Issues Created
  • Update CHANGELOG.md
  • For API changes, the Postman collection has been updated
  • If there are any database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!

@RobertKeyser RobertKeyser self-assigned this May 30, 2024
Copy link

vercel bot commented May 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
fides-plus-nightly ⬜️ Ignored (Inspect) Visit Preview May 30, 2024 5:11pm

Copy link

cypress bot commented May 30, 2024

Passing run #8003 ↗︎

0 4 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge 1e320fd into 8309e83...
Project: fides Commit: d212a6aab3 ℹ️
Status: Passed Duration: 00:35 💡
Started: May 30, 2024 5:02 PM Ended: May 30, 2024 5:03 PM

Review all test suite changes for PR #4936 ↗︎

@RobertKeyser RobertKeyser merged commit 06d373c into main May 30, 2024
11 checks passed
@RobertKeyser RobertKeyser deleted the rkeyser/fix-pc-wording branch May 30, 2024 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants