-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add integration for Alchemer Erasure #4925
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Passing run #8907 ↗︎
Details:
Review all test suite changes for PR #4925 ↗︎ |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4925 +/- ##
==========================================
- Coverage 86.50% 86.44% -0.07%
==========================================
Files 353 354 +1
Lines 22176 22201 +25
Branches 2920 2925 +5
==========================================
+ Hits 19184 19192 +8
- Misses 2478 2495 +17
Partials 514 514 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This all works as expected, I just made some recommendations to make things more consistent and easier to troubleshoot in the future.
src/fides/api/service/saas_request/override_implementations/alchemer_request_overrides.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a bit more cleanup and this one is good to go!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making the suggested changes! I like how you were able to get this to work with the request override 👍
Passing run #8911 ↗︎
Details:
Review all test suite changes for PR #4925 ↗︎ |
Closes #INTS-2
Description Of Changes
Added integration for Alchemer, erasure only
Code Changes
Steps to Confirm
Pre-Merge Checklist
https://github.com/ethyca/fidesdocs/pull/372
https://github.com/ethyca/fidesdocs/issues/373
CHANGELOG.md