Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add integration for Alchemer Erasure #4925

Merged
merged 49 commits into from
Jul 15, 2024
Merged

Add integration for Alchemer Erasure #4925

merged 49 commits into from
Jul 15, 2024

Conversation

MarcGEthyca
Copy link
Contributor

@MarcGEthyca MarcGEthyca commented May 24, 2024

Closes #INTS-2

Description Of Changes

Added integration for Alchemer, erasure only

Code Changes

  • Added config, icon, dataset, tests and fixtures for Alchemer integration

Steps to Confirm

  • Add/configure the connector in UI
  • Verify config and icon UI looks good
  • Ensure the test integration button works

Pre-Merge Checklist

Copy link

vercel bot commented May 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fides-plus-nightly ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 15, 2024 4:45pm

Copy link

cypress bot commented May 24, 2024

Passing run #8907 ↗︎

0 4 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge fa48624 into e02e6e1...
Project: fides Commit: 6fc0968010 ℹ️
Status: Passed Duration: 00:34 💡
Started: Jul 15, 2024 4:53 PM Ended: Jul 15, 2024 4:53 PM

Review all test suite changes for PR #4925 ↗︎

Copy link

codecov bot commented May 24, 2024

Codecov Report

Attention: Patch coverage is 32.00000% with 17 lines in your changes missing coverage. Please review.

Project coverage is 86.44%. Comparing base (e02e6e1) to head (fa48624).

Files Patch % Lines
...ride_implementations/alchemer_request_overrides.py 32.00% 17 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4925      +/-   ##
==========================================
- Coverage   86.50%   86.44%   -0.07%     
==========================================
  Files         353      354       +1     
  Lines       22176    22201      +25     
  Branches     2920     2925       +5     
==========================================
+ Hits        19184    19192       +8     
- Misses       2478     2495      +17     
  Partials      514      514              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MarcGEthyca MarcGEthyca self-assigned this Jun 4, 2024
@galvana galvana marked this pull request as ready for review July 12, 2024 16:46
@galvana galvana requested a review from a team as a code owner July 12, 2024 16:46
Copy link
Contributor

@galvana galvana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all works as expected, I just made some recommendations to make things more consistent and easier to troubleshoot in the future.

data/saas/config/alchemer_config.yml Outdated Show resolved Hide resolved
data/saas/dataset/alchemer_dataset.yml Show resolved Hide resolved
tests/fixtures/saas/alchemer_fixtures.py Outdated Show resolved Hide resolved
Copy link
Contributor

@galvana galvana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a bit more cleanup and this one is good to go!

data/saas/dataset/alchemer_dataset.yml Outdated Show resolved Hide resolved
tests/fixtures/saas/alchemer_fixtures.py Outdated Show resolved Hide resolved
tests/fixtures/saas/alchemer_fixtures.py Outdated Show resolved Hide resolved
tests/fixtures/saas/alchemer_fixtures.py Outdated Show resolved Hide resolved
data/saas/dataset/alchemer_dataset.yml Outdated Show resolved Hide resolved
Copy link
Contributor

@galvana galvana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the suggested changes! I like how you were able to get this to work with the request override 👍

@galvana galvana merged commit 75b7dda into main Jul 15, 2024
44 of 45 checks passed
@galvana galvana deleted the fides_ints_2_alchemer branch July 15, 2024 17:40
Copy link

cypress bot commented Jul 15, 2024

Passing run #8911 ↗︎

0 4 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Add integration for Alchemer Erasure (#4925)
Project: fides Commit: 75b7dda93c
Status: Passed Duration: 00:35 💡
Started: Jul 15, 2024 5:50 PM Ended: Jul 15, 2024 5:51 PM

Review all test suite changes for PR #4925 ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants