Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker Compose - Change privacy center port to 3001 #4918

Merged
merged 2 commits into from
May 24, 2024

Conversation

RobertKeyser
Copy link
Contributor

Closes PROD-2120

Description Of Changes

Following up on #4912, we need to also add the new port to the Docker Compose file, so it works in Nox. Currently nox -s pc expects it to be exposed on port 3000, which leads to a network error when trying to access it via http://localhost:3001.

Code Changes

  • list your code changes here

Steps to Confirm

  • Run nox -s pc and confirm that http://localhost:3001 properly serves the privacy center.

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Documentation:
  • Issue Requirements are Met
  • Relevant Follow-Up Issues Created
  • Update CHANGELOG.md
  • For API changes, the Postman collection has been updated
  • If there are any database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!

@RobertKeyser RobertKeyser self-assigned this May 23, 2024
Copy link

vercel bot commented May 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
fides-plus-nightly ⬜️ Ignored (Inspect) Visit Preview May 23, 2024 9:18pm

Copy link

cypress bot commented May 23, 2024

Passing run #7910 ↗︎

0 4 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge 4b3f641 into f3b7d0d...
Project: fides Commit: 673781eb7c ℹ️
Status: Passed Duration: 00:36 💡
Started: May 23, 2024 9:29 PM Ended: May 23, 2024 9:29 PM

Review all test suite changes for PR #4918 ↗︎

Copy link
Contributor

@adamsachs adamsachs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @RobertKeyser!

Copy link
Contributor

@lucanovera lucanovera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for catching this and creating the PR!

@RobertKeyser RobertKeyser merged commit 967109f into main May 24, 2024
25 of 26 checks passed
@RobertKeyser RobertKeyser deleted the rkeyser/prod-2120 branch May 24, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants