Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TCF styling updates #4904

Merged
merged 8 commits into from
May 24, 2024
Merged

TCF styling updates #4904

merged 8 commits into from
May 24, 2024

Conversation

Kelsey-Ethyca
Copy link
Contributor

@Kelsey-Ethyca Kelsey-Ethyca commented May 22, 2024

Closes #2093

Description Of Changes

remove second toggle
left align text, right align toggle

Code Changes

  • css update to align text and dropdown toggle
  • html updates to remove second dropdown arrow

Steps to Confirm

Pre-Merge Checklist

TCF BANNER

Screenshot 2024-05-21 at 5 26 00 PM

TCF EMBEDDED

Screenshot 2024-05-21 at 5 26 55 PM

NON-TCF

Screenshot 2024-05-21 at 5 27 17 PM

remove second toggle
left align text, right align toggle
Copy link

vercel bot commented May 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fides-plus-nightly ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 24, 2024 3:57pm

Copy link

cypress bot commented May 22, 2024

Passing run #7924 ↗︎

0 4 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge 7ce6787 into b4d743f...
Project: fides Commit: 7c4f56b820 ℹ️
Status: Passed Duration: 00:35 💡
Started: May 24, 2024 3:17 AM Ended: May 24, 2024 3:18 AM

Review all test suite changes for PR #4904 ↗︎

@NevilleS
Copy link
Contributor

Can you test the regular (non-TCF) toggles as well? For example, this is on the current release:
image

That animated arrow (created by the CSS pseudo-element .fides-notice-toggle-trigger:before) is left-aligned there, which I think generally makes sense for our "notice" component because we have other interactive elements on the right-hand side (toggle switch, IAB label, GPC label, etc.)

Copy link
Contributor

@lucanovera lucanovera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right amount of toggles and they're in the right places: Approved.
You may want to update the changelog.

@Kelsey-Ethyca Kelsey-Ethyca merged commit 35fae15 into main May 24, 2024
10 of 11 checks passed
@Kelsey-Ethyca Kelsey-Ethyca deleted the PROD-2093-tcf-banner-styling-bugs branch May 24, 2024 15:55
Kelsey-Ethyca added a commit that referenced this pull request May 24, 2024
@cypress cypress bot mentioned this pull request May 24, 2024
31 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants