-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use CheckboxTree for data map filtering #4864
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Passing run #7628 ↗︎
Details:
Review all test suite changes for PR #4864 ↗︎ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested this, and it works great! Couple small requests below.
Also here's some things I've noticed that I'm unsure if caused by this PR, but would like to double check:
- The vertical spacing between items within the accordions seems uneven:
- The
group_by
query param seems to have some encoding issues in the resulting API call:
Let me know and let's re-ticket items as needed!
I think that was existing, but it's an easy fix. Great catch. |
That's also existing behavior, and I'm worried about breaking it for the backend. Might be best to re-ticket that one as you suggested. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making those changes!
Mind creating a new ticket for the query param formatting?
Closes PROD-1916
Description Of Changes
Update the filters on the table to apply a modified version of the hierarchy component that we are using on the dataset page.
Code Changes
DatamapReportFilterModal
which reduces a lot of over-engineered complexity and implements theCheckboxTree
componentgetQueryParamsFromList
as newgetQueryParamsFromArray
utilitySteps to Confirm
/reporting/datamap
Pre-Merge Checklist
CHANGELOG.md