Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update getDataDisplayName to accept levels #4856

Merged
merged 4 commits into from
May 2, 2024
Merged

Update getDataDisplayName to accept levels #4856

merged 4 commits into from
May 2, 2024

Conversation

gilluminate
Copy link
Contributor

@gilluminate gilluminate commented May 2, 2024 •
edited
Loading

Closes PROD-1991

Description Of Changes

Update getDataDisplayName utility to accept a level to return the primary label. This way we can pass a level 2 to when retrieving categories.

Steps to Confirm

  • Visit Data Map Report table page /reporting/datamap
  • Expand the Categories column so that all the badges are broken out individually rather than combined
  • Note that before this fix, nearly all of them used a generic "User Data" label and now with this fix those primary, bold labels display the secondary level instead.

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Issue Requirements are Met
  • Update CHANGELOG.md

@vercel Vercel
Copy link

vercel bot commented May 2, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fides-plus-nightly ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 2, 2024 6:55pm

@cypress Cypress
Copy link

cypress bot commented May 2, 2024 •
edited
Loading

Passing run #7578 ↗︎

0 4 0 0 Flakiness 0

Details:

Merge 7fb0364 into 8165baf...
Project: fides Commit: cc6d46811b ℹ️
Status: Passed Duration: 00:35 💡
Started: May 2, 2024 7:07 PM Ended: May 2, 2024 7:07 PM

Review all test suite changes for PR #4856 ↗︎

@gilluminate gilluminate marked this pull request as ready for review May 2, 2024 18:35
lucanovera
lucanovera approved these changes May 2, 2024
View reviewed changes
Copy link
Contributor

@lucanovera lucanovera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Approve

@gilluminate gilluminate merged commit 2c95044 into main May 2, 2024
13 checks passed
@gilluminate gilluminate deleted the PROD-1991-update-data-map-report-data branch May 2, 2024 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucanovera lucanovera lucanovera approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gilluminate @lucanovera