Update the get_cached_identity_data function to support non-JSON-encoded value

[galvana]

Closes PROD-2009

Description Of Changes

This is a fix for a defect that was introduced with the custom identities feature, specifically this line. Moving forward, we want to make sure that any non-JSON-encoded values in the cache can still be read. There is no data lost between the two caching methods since we're just formatting the values differently. This means the change can be targeted and everything can continue to work as expected as long as get_cached_identity_data returns the expected response.

Code Changes

• Updated get_cached_identity_data and added a test

Steps to Confirm

• This one is tricky to verify since it involves queuing a privacy request pre-2.34, upgrading to 2.34 then approving the request. I just wrote a test to make sure we could reproduce the issue reported in prod and verify the fix.

Pre-Merge Checklist

• All CI Pipelines Succeeded
• Issue Requirements are Met
• Update CHANGELOG.md

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
fides-plus-nightly	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	May 3, 2024 3:15pm

[cypress]

Passing run #7577 ↗︎

0

4

0

0

0

Details:

Merge 79d0cd9 into 8165baf...
Project: fides	Commit: 11ba5ead22 ℹ️
Status: Passed	Duration: 00:35 💡
Started: May 2, 2024 6:50 PM	Ended: May 2, 2024 6:50 PM

Review all test suite changes for PR #4855 ↗︎

[adamsachs]

this makes sense to me @galvana! just one minor nit on potentially adding some more context around the code comment, to be extra sure that this isn't confusing for anyone looking at this moving forward.

also, as i mentioned separately - it was a bit surprising to me that we're keeping the cache in tact across upgrades, but i guess that makes sense. in any case, this is a good, defensive measure 👍

oh, and nice job on adding in the test coverage!🏅

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.79%. Comparing base (8165baf) to head (79d0cd9).
Report is 3 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #4855   +/-   ##
=======================================
  Coverage   86.78%   86.79%           
=======================================
  Files         346      346           
  Lines       20913    20917    +4     
  Branches     2733     2733           
=======================================
+ Hits        18150    18154    +4     
  Misses       2288     2288           
  Partials      475      475           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.